Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #87 breaks the use of MinGW make on Windows #88

Closed
lukebakken opened this issue Dec 5, 2022 · 0 comments · Fixed by #89
Closed

PR #87 breaks the use of MinGW make on Windows #88

lukebakken opened this issue Dec 5, 2022 · 0 comments · Fixed by #89

Comments

@lukebakken
Copy link
Contributor

lukebakken commented Dec 5, 2022

#87

Output follows. Note that I have to type exit to exit the interactive shell.

C:\Users\bakkenl\AppData\Local\nvim\pack\nvim-telescope\start\telescope-fzf-native.nvim>make --version
GNU Make 4.3
Built for Windows32
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

C:\Users\bakkenl\AppData\Local\nvim\pack\nvim-telescope\start\telescope-fzf-native.nvim>git clean -xffd

C:\Users\bakkenl\AppData\Local\nvim\pack\nvim-telescope\start\telescope-fzf-native.nvim>make
cmd //C mkdir build
Microsoft Windows [Version 10.0.22000.1219]
(c) Microsoft Corporation. All rights reserved.

C:\Users\bakkenl\AppData\Local\nvim\pack\nvim-telescope\start\telescope-fzf-native.nvim>exit
gcc -O3 -Wall -Werror -fpic -std=gnu99 -shared src/fzf.c -o build/libfzf.dll
c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot open output file build/libfzf.dll: No such file or directory
collect2.exe: error: ld returned 1 exit status
make: *** [Makefile:18: build/libfzf.dll] Error 1

The fix is to revert the extra escaping introduced in #87, or to improve system detection.

I'll open a PR to address this.

lukebakken added a commit to lukebakken/telescope-fzf-native.nvim that referenced this issue Dec 5, 2022
@lukebakken lukebakken mentioned this issue Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant