Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon hl width for various pickers #2450

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

jamestrew
Copy link
Contributor

@jamestrew jamestrew commented Apr 2, 2023

Description

Fix the highlight group width for devicons for various pickers' entry display.
Currently, certain entry makers fail to compensate for the icon widths not equal to 3.
Closes #2445

Effects pickers using gen_from_file and gen_from_vimgrep make entries.

  • find_files
  • git_files
  • oldfiles
  • live_grep
  • grep_string

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration

Configuration:

  • Neovim version (nvim --version): NVIM v0.9.0-dev-1305+g83bfd94d1
  • Operating system and version: Linux archlinux 6.2.8-arch1-1

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@jamestrew jamestrew marked this pull request as ready for review April 2, 2023 18:34
@Conni2461
Copy link
Member

thanks :)

@Conni2461 Conni2461 merged commit c20d4fb into nvim-telescope:master Apr 9, 2023
@Conni2461
Copy link
Member

also thanks for maintaining issues, while i was away :) I'll try to spend more time on telescope in the next couple of days, fingers crossed

Conni2461 pushed a commit that referenced this pull request Apr 9, 2023
@jamestrew jamestrew deleted the fix/devicon-hling branch April 9, 2023 19:47
abelmul pushed a commit to abelmul/telescope.nvim that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon/color overrides in nvim-web-devicons are not respected
2 participants