Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtin.commands): Don't remap feedkeys #3087

Merged
merged 1 commit into from
May 3, 2024

Conversation

parmort
Copy link
Contributor

@parmort parmort commented May 2, 2024

Description

If the user remapped :, the builtin.commands picker would use the remapped : instead of inserting a command, which would lead to unintended behavior. My configuration swaps ; and : around, which would lead to the keys in the command being inputted as normal mode commands. To make sure a command is inputted as expected, adding the n flag to feedkeys makes sure nvim uses the defaults.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Interactive test, both on my full config and on a minimal config

Configuration:

  • Neovim version (nvim --version):
NVIM v0.9.5
Build type: RelWithDebInfo
LuaJIT 2.1.1692716794
  • Operating system and version: Arch Linux x86_64, 6.8.5-arch1-1

@jamestrew
Copy link
Contributor

My configuration swaps ; and : around

😲

thanks!

@jamestrew jamestrew merged commit 486a648 into nvim-telescope:master May 3, 2024
8 of 9 checks passed
@jamestrew jamestrew added the backport-0.1.x PR to be backported to 0.1.x (Neovim 0.7 compat) label May 3, 2024
Conni2461 pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-0.1.x PR to be backported to 0.1.x (Neovim 0.7 compat)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants