-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(#2827): multi instance nvim-tree.live-filter #2849
Conversation
Nice. I can see you on the board. Added the issue in the description so that the PR also shows. |
Are you able to drag the issue on the board to "in progress"? New to github projects and trying to sort out permissions... |
Inside the issue I can do almost everything but unfortunately project board is not interactive for me. |
Not looking good for auto transitions: https://github.com/orgs/community/discussions/72699 I think I've added you this time; you should have full access to the project. |
yup, now it works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, works as expected!
You are getting practiced at this.
Co-authored-by: Alexander Courtis <alex@courtis.org>
…tree.lua into live-filter-multiinstace
For the next two weeks, I won't be available, but don't worry, I'll be back. |
@@ -112,7 +112,10 @@ function M.find_node(nodes, fn) | |||
end) | |||
:iterate() | |||
i = require("nvim-tree.view").is_root_folder_visible() and i or i - 1 | |||
i = require("nvim-tree.live-filter").filter and i + 1 or i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
@@ -112,7 +112,10 @@ function M.find_node(nodes, fn) | |||
end) | |||
:iterate() | |||
i = require("nvim-tree.view").is_root_folder_visible() and i or i - 1 | |||
i = require("nvim-tree.live-filter").filter and i + 1 or i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
No pressure at all. This is a slow burn... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your contribution!
fixes #2827
This is not ready yet. Just putting it here to indicate that I'm working on it.
Also would be nice to have things from other PRs to not duplicate the work.