Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(#2827): multi instance nvim-tree.live-filter #2849

Merged
merged 11 commits into from
Aug 10, 2024

Conversation

raaymax
Copy link
Collaborator

@raaymax raaymax commented Jul 23, 2024

fixes #2827

This is not ready yet. Just putting it here to indicate that I'm working on it.
Also would be nice to have things from other PRs to not duplicate the work.

@raaymax raaymax changed the title feat(#2827): Multi Instance: Refactor: nvim-tree.live-filter refactor(#2827): Multi Instance: Refactor: nvim-tree.live-filter Jul 23, 2024
@raaymax raaymax changed the title refactor(#2827): Multi Instance: Refactor: nvim-tree.live-filter refactor(#2827): multi instance nvim-tree.live-filter Jul 23, 2024
@alex-courtis
Copy link
Member

Nice. I can see you on the board.

Added the issue in the description so that the PR also shows.

@alex-courtis
Copy link
Member

Are you able to drag the issue on the board to "in progress"?

New to github projects and trying to sort out permissions...

@raaymax
Copy link
Collaborator Author

raaymax commented Jul 27, 2024

Inside the issue I can do almost everything but unfortunately project board is not interactive for me.

@alex-courtis
Copy link
Member

Inside the issue I can do almost everything but unfortunately project board is not interactive for me.

Not looking good for auto transitions: https://github.com/orgs/community/discussions/72699

I think I've added you this time; you should have full access to the project.

@raaymax raaymax marked this pull request as ready for review July 28, 2024 09:38
@raaymax
Copy link
Collaborator Author

raaymax commented Jul 28, 2024

yup, now it works

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, works as expected!

You are getting practiced at this.

lua/nvim-tree/api.lua Outdated Show resolved Hide resolved
lua/nvim-tree/explorer/live-filter.lua Show resolved Hide resolved
@raaymax
Copy link
Collaborator Author

raaymax commented Aug 4, 2024

For the next two weeks, I won't be available, but don't worry, I'll be back.

@@ -112,7 +112,10 @@ function M.find_node(nodes, fn)
end)
:iterate()
i = require("nvim-tree.view").is_root_folder_visible() and i or i - 1
i = require("nvim-tree.live-filter").filter and i + 1 or i
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@@ -112,7 +112,10 @@ function M.find_node(nodes, fn)
end)
:iterate()
i = require("nvim-tree.view").is_root_folder_visible() and i or i - 1
i = require("nvim-tree.live-filter").filter and i + 1 or i
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@alex-courtis
Copy link
Member

For the next two weeks, I won't be available, but don't worry, I'll be back.

No pressure at all. This is a slow burn...

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution!

@alex-courtis alex-courtis merged commit 15942df into master Aug 10, 2024
5 checks passed
@alex-courtis alex-courtis deleted the live-filter-multiinstace branch August 10, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi Instance: Refactor: nvim-tree.live-filter
2 participants