-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update ts, cts, mts and tsconfig.json icon #376
Conversation
Thank you for finding all these inconsistencies in the various script icons. The test icons were added #215 based on vscode and are not "official" javascript icons. It appears that they are the material icons rather than the seti icons. |
Idea: audit the icons noting the class and hex. This could be done during generate_colors.lua and comments added to the icon. Lua 5.3+ utf8 support would provide this. |
Maybe it's time to introduce icon sets? Or pick one style and support only that one. Consistency is a good thing. |
Yes. We seem to mainly use seti, octicons, devicons and material. Let's see how an audit goes. |
Some analysis, mapping the icons to their nerd-font classes: https://gist.github.com/alex-courtis/26271d581e390fe26058bf0743539cc3 TL;DR: we are using mostly seti and dev with some material design and font awesome.
I'm happy to pick seti and use that for the defaults. Users can add different icon sets via setup and I think there is a material configuration out there somewhere. A contributor could add icon sets with plumbing to nvim-web-devicons if they are motivated. It might be time to reopen #192 which will be simpler now that we have the generation scripts. |
The original ts and js icons keeps the same style:
But 808627b and 33e27b8 break this:
So I recommend to update the ts icon as well:
And use the original ts icon for
tsconfig.json
, because they are very similar.But what I recommend most is to revert these two PRs directly. There is no reason to do this update, and this also affects the uniform style of other icons, for test.js
This new icon is a completely different style:
Note:
I'm not swapping icons for tsconfig and ts, These two icons look the same but they have very subtle differences. These are two icons with different code points. Compare to ts:
e69d(nf-seti-tsconfig):
![image](https://private-user-images.githubusercontent.com/61115159/296136093-6797ecff-f1c3-4ac8-a06c-7ee80a013df1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyNjA1MzEsIm5iZiI6MTcyNDI2MDIzMSwicGF0aCI6Ii82MTExNTE1OS8yOTYxMzYwOTMtNjc5N2VjZmYtZjFjMy00YWM4LWEwNmMtN2VlODBhMDEzZGYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIxVDE3MTAzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM4MWQ0NmI5NjI2MzQ3NmUyZDA2NTllOGU0NDNiY2E2MDM1NjY2MTEyNDk2YmQzMDRkNjcwMzZkMmNmY2Y2NWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2F9geC2LZeVflQga3qOlUEcrWZ3-1Ws9K49gIj9QZic)
f06e6(nf-md-language_typescript):
![image](https://private-user-images.githubusercontent.com/61115159/296136541-3c3f7f6b-c926-4677-943e-4b7b38ffa3c1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyNjA1MzEsIm5iZiI6MTcyNDI2MDIzMSwicGF0aCI6Ii82MTExNTE1OS8yOTYxMzY1NDEtM2MzZjdmNmItYzkyNi00Njc3LTk0M2UtNGI3YjM4ZmZhM2MxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIxVDE3MTAzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJjYTY0MmE3OTRiMDU3MDk0MDQ1MWZlYmM1NjVjYjJhMDAxNjE0NTVjZmQyMjUwY2VlMGUyMDljYjg5NjhiMjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Y6QNaK6RKyGiTAqCM75vLZHTNSd6ZhP3GiOfgG2d6oI)