chore!: deprecate ensure_installed=maintained #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyazdani42
approved these changes
Apr 9, 2022
|
(updated the documentation and README as well) |
theHamsta
reviewed
Apr 9, 2022
theHamsta
reviewed
Apr 9, 2022
BREAKING CHANGE: specify explicit list or use `ensure_installed='all'` (not recommended)
|
I've removed all mention of |
|
@theHamsta I'll merge (and announce) this after your approval. |
theHamsta
approved these changes
Apr 10, 2022
stefanvanburen
added a commit
to stefanvanburen/dotfiles
that referenced
this pull request
Apr 11, 2022
"maintained" is deprecated.[1] "all" is not recommended (according to the new docs) so I've started this out with just "go" support and will add more languages here as I need them. [1]: nvim-treesitter/nvim-treesitter#2763
Aetf
added a commit
to Aetf/ucw.nvim
that referenced
this pull request
Apr 12, 2022
Using all isn't recommended. See nvim-treesitter/nvim-treesitter#2763.
khuedoan
pushed a commit
to khuedoan/dotfiles
that referenced
this pull request
Apr 12, 2022
"maintained" is deprecated. nvim-treesitter/nvim-treesitter#2763
khuedoan
added a commit
to khuedoan/dotfiles
that referenced
this pull request
Apr 12, 2022
"maintained" is deprecated. nvim-treesitter/nvim-treesitter#2763
tssujt
added a commit
to tssujt/dotfiles
that referenced
this pull request
Apr 13, 2022
fnichol
added a commit
to fnichol/dotneovim
that referenced
this pull request
Apr 14, 2022
Upstream plugin has migrated away from `"maintained"`, so we'll enumerate our desired set instead! References: nvim-treesitter/nvim-treesitter#2763 Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
qbantek
added a commit
to qbantek/dotfiles
that referenced
this pull request
Apr 18, 2022
zdzolton
added a commit
to zdzolton/neovimconf
that referenced
this pull request
May 3, 2022
The no longer support the `maintained` option for the ensure_installed config setting, so I've opted for an explicit list for now... nvim-treesitter/nvim-treesitter#2763 (Sounds like `all` isn't suggested...)
ogirginc
added a commit
to ogirginc/dotfiles
that referenced
this pull request
May 4, 2022
- Install all to "drink from the firehose"[1] - Ignore broken phpdoc[2] [1] nvim-treesitter/nvim-treesitter#2763 nvim-treesitter/nvim-treesitter#2809 [2] nvim-treesitter/nvim-treesitter#2837
Edditoria
added a commit
to Edditoria/eddinvim
that referenced
this pull request
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the increasing number of parsers added to
nvim-treesitter, the label "maintained" has stopped being a useful distinction, as just having a maintainer listed at time of inclusion does not entail any stability guarantee implied by this label. Users should explicitly specify the list of parsers that they want to use according to their risk tolerance, or useensure_installed = 'all'if they insist on drinking from the firehose (not recommended!)Deprecation period is until April 30; hopefully that will leave enough time for the ecosystem to adapt.
The warning is emitted from
parsers.maintained_parsers()in the hope that this will be most visible (and not break CI).@theHamsta @vigoux @kyazdani42