Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop #13

Closed
wants to merge 2 commits into from
Closed

Fix rubocop #13

wants to merge 2 commits into from

Conversation

kassio
Copy link

@kassio kassio commented Sep 15, 2023

No description provided.

@xiaoshihou514
Copy link
Collaborator

Thanks for fixing this! Could you maybe write a test to verify it's parsing diagnostics correctly? There are insturctions for doing so in CONTRIBUTING.md

@kassio
Copy link
Author

kassio commented Sep 17, 2023

I tried to add tests, but this is a bit tricky as we'd need to install bundler, run bundle install before really executing bundle exec rubocop...

Is it possible to configure a linter/formatter partially? If so we could change the cmd/args to not use bundler by default. 🤷

@@ -26,21 +26,22 @@
- [ ] [rubocop](https://github.com/rubocop/rubocop)
- [x] [rustfmt](https://github.com/rust-lang/rustfmt)
- [ ] [shfmt](https://github.com/mvdan/sh)
- [x] [sql-formatter](https://github.com/sql-formatter-org/sql-formatter)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted the list

@xiaoshihou514
Copy link
Collaborator

xiaoshihou514 commented Sep 18, 2023

I tried to add tests, but this is a bit tricky as we'd need to install bundler, run bundle install before really executing bundle exec rubocop...

You can just put the table in the config, change the cmd, test that it's ok, and put the string back. That should ensure the config at least works. (small changes between versions isn't that important)

Is it possible to configure a linter/formatter partially? If so we could change the cmd/args to not use bundler by default. 🤷

One could require the parse field from the repo I guess🤔, but it's up to you, if you think more people use rubocop not installed by bundler feel free to change that.

@kassio
Copy link
Author

kassio commented Sep 18, 2023

I decided to not use guard.nvim anymore. Thanks for the plugin, but it's not for me.

@kassio kassio closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants