lspsaga is incompatible (and will remain unless updated) with neovim 0.5.1 and the nightly

[mjlbach]

We merged neovim/neovim#15504 which changes the signature of the built-in handlers.

lspsaga has not been updated, and is no longer compatible with the latest nightly. If users are interested in the functionality of lspsaga, I would a community members forks and updates the handler until development of lspsaga is resumed.

I will briefly note, that borders are now available in core, so the main things that are missing from lspsaga are the popup references/rename windows.

[dominikhaid]

Can we already download the fork somewhere?
For me, Signature Help is not working, and the hover render.

[mjlbach]

There's no fork, someone will have to make it.

[kkharji]

No promises, but I have forked and merged #207. I may tackle the incompatible issue later this week

[rinx]

The issues about code action, signature help and hover doc are fixed on my fork.
https://github.com/rinx/lspsaga.nvim

@tami5 Please feel free to chery-pick or merge the commits into your fork.

[kkharji]

The issues about code action, signature help and hover doc are fixed on my fork.
https://github.com/rinx/lspsaga.nvim

@tami5 Please feel free to chery-pick or merge the commits into your fork.

Oh nice, Thanks @rinx

[sbmueller]

Neovim 0.5.1 has been released a few days ago. Is this issue still present with the released version? I can't seem to get lspsaga running.

[mjlbach]

There is no bug in neovim, we made a backwards incompatible change which is present in 0.5.1 (and will be in all versions going forward). Until lspsaga is updated, I would recommend using https://github.com/tami5/lspsaga.nvim

[sbmueller]

@mjlbach thanks, care to open a PR against this repo to speed up the process?

EDIT: I misread your last comment, understanding you pointing me to your own fork, where you already authored a fix. In that case, I would find it perfectly normal to kindly ask for a PR. Since that is not the case, please ignore my comment. Please don't interpret this misunderstanding as demanding attitude.

[mjlbach]

@sbmueller the last PR that was merged was done on April 25th of this year (cb0e35d). I already redirected users to tami's fork, so I fail to see how me filing a PR from that fork onto this repo will speed things up given the lack of activity on this repo. I've also never used lspsaga, I'm just the core member who wrote/merged the handler change that broke lspsaga, so this was my PSA.

[kkharji]

@sbmueller the last PR that was merged was done on April 25th of this year (cb0e35d). I already redirected users to tami's fork, so I fail to see how me filing a PR from that fork onto this repo will speed things up given the lack of activity on this repo. I've also never used lspsaga, I'm just the core member who wrote/merged the handler change that broke lspsaga, so this was my PSA.

Indeed @mjlbach is very valuable member and quite frankly is more important doing CORE stuff that support such a wonderful ecosystem and community. It just so nice of him to care for us as lspsaga users to have risen attention regarding a breaking change.

@sbmueller if a user is using something and notices an issue or opportunity for improvement is to basically try to raise attention, 2. try to do it if you can through pr and seek help for doing it. Else, find an alternative and don't use it (i don't know if you know but in Open Source, no one is making any real-world gain to be asked todo something in a manner of demanding. I think his contribute to the fact that we have a lot of ghost repos on github and many alternatives)..... Anyway, I'm a bit busy with work and currently trying to have the time to update my nvim and do fixes when I use lspsaga+nvim5.1 a daily driver. Otherwise, feel free to open pr in:: https://github.com/tami5/lspsaga.nvim

This what started the fork in case you don't know :)

No promises, but I have forked and merged #207. I may tackle the incompatible issue later this week

[sbmueller]

@tami5 thanks for the context. With this repo being inactive for so many months, things get clearer.
Also, I see @al3xfischer has opened a PR with your fix against this repo, thanks for that!