-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin_1_states_provinces: Regions of France was updated in 2016 #429
Comments
Who's On First has been updated, so pull those updates in here. |
Verified Proposed Changes: Update region names and codes per https://fr.wikipedia.org/wiki/ISO_3166-2:FR, as seen in table below. Region codes will be modified for all features, and region names updated where they were changed ( "-" indicates no change) For overseas departments, value for region code is currently department code. Proposing to update these also to 3 letter region codes, to standardize length of codes (FR-XYZ).
|
Updated regions and region codes per nvkelso#429 Region codes were updated, and names did not change for Bretagne, Île-de-France, Provence-Alpes-Côte-d'Azur, and Pays de la Loire. Codes for overseas departments were changed from department code to region code, but region names did not change. All other regions were updated with new codes and names. Changes are only to .dbf
Updated regions and region codes per nvkelso#429 Region codes were updated, and names did not change for Bretagne, Île-de-France, Provence-Alpes-Côte-d'Azur, and Pays de la Loire. Codes for overseas departments were changed from department code to region code, but region names did not change. All other regions were updated with new codes and names. Changes are only to ne_10m_admin_1_states_provinces.dbf
Trying this one more time, updating attributes per nvkelso#429 via process in nvkelso#396 -- $ make build_a7_ne_10m_admin_1_all mkdir -p intermediate mapshaper -i 10m_physical/ne_10m_lakes.shp \ -filter 'scalerank <= 0' + \ -o intermediate/ne_10m_lakes_big.shp \ [filter] Retained 18 of 1,354 features [o] Wrote intermediate/ne_10m_lakes_big.shp [o] Wrote intermediate/ne_10m_lakes_big.shx [o] Wrote intermediate/ne_10m_lakes_big.dbf [o] Wrote intermediate/ne_10m_lakes_big.prj mapshaper -i combine-files snap \ 10m_cultural/ne_10m_admin_0_boundary_lines_land.shp \ 10m_cultural/ne_10m_admin_0_boundary_lines_map_units.shp \ 10m_physical/ne_10m_coastline.shp \ 10m_physical/ne_10m_minor_islands_coastline.shp \ 10m_cultural/ne_10m_admin_1_states_provinces_lines.shp \ 10m_cultural/ne_10m_admin_1_seams.shp \ -filter-fields \ -merge-layers \ -polygons gap-tolerance=1e-4 \ -join 10m_cultural/ne_10m_admin_1_label_points.shp \ -filter 'adm0_sr !== null' + \ -o 10m_cultural/ne_10m_admin_1_states_provinces_scale_rank_minor_islands.shp \ -filter 'adm0_sr <= 6' + \ -o 10m_cultural/ne_10m_admin_1_states_provinces_scale_rank.shp \ -dissolve 'adm1_code' copy-fields=featurecla,scalerank \ -join 10m_cultural/ne_10m_admin_1_label_points_details.dbf encoding=utf8 keys=adm1_code,adm1_code fields=* \ -o 10m_cultural/ne_10m_admin_1_states_provinces.shp \ -erase intermediate/ne_10m_lakes_big.shp \ -o 10m_cultural/ne_10m_admin_1_states_provinces_lakes.shp \ # calc='join_count = count()' [i] Snapped 4635 points [join] Joined data from 11,284 source records to 11,283 target records [join] 4/11287 target records received no data [join] 1/11287 target records were matched by multiple source records (many-to-one relationship) [join] Inconsistent values were found in fields [OBJECTID_1,diss_me,adm1_code,name] during many-to-one join. Values in the first joining record were used. [filter] Retained 11,283 of 11,287 features [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_scale_rank_minor_islands.shp [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_scale_rank_minor_islands.shx [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_scale_rank_minor_islands.dbf [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_scale_rank_minor_islands.prj [filter] Retained 8,534 of 11,283 features [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_scale_rank.shp [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_scale_rank.shx [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_scale_rank.dbf [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_scale_rank.prj [dissolve] Dissolved 8,534 features into 4,593 features [join] Joined data from 4,593 source records to 4,593 target records [join] 54/4647 source records could not be joined [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces.shp [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces.shx [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces.dbf [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces.prj [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_lakes.shp [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_lakes.shx [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_lakes.dbf [o] Wrote 10m_cultural/ne_10m_admin_1_states_provinces_lakes.prj --
I spot checked the changes in this PR and they look great, thanks! To recap: in 2016 the existing French "departments" (what Natural Earth considers admin-1) were regrouped into new "regions" (which NE tracks as groupings of admin-1), so the work in this PR so far establishes the new region names and region codes in the admin-1 data tables. This took the number of enumerated metropolitan regions from "22 to 13". One thing to verify together... this PR should be coherent with the boundary lines, too. (below) Blue lines are department boundaries, red lines are ALSO region boundaries – but are they pre-2016 regions? Compare with what Wikipedia has for the 13 metropolitan French regions – the NE red lines should match: This involves changing the featurecla between But it looks like those were changed at some point already? Running
Because you're working off the v5-prequel branch you get this change for free (a few months before Arlo was born and I went MIA), even though it hasn't been released yet :) So I'll merge the PR now! |
Fixed via #514. |
In admin_1_states_provinces data, the region attributes of French provinces are still in the old divisions. Since 2016 France is mainly divided into 18 new administrative regions: 13 regions in metropolitan France (including the territorial collectivity of Corsica).
The text was updated successfully, but these errors were encountered: