-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvm use
should write a .nvmrc
file by default
#2849
Comments
I definitely don't think this should be done by default; just because someone is I think some kind of option on |
That makes sense. For the record, I think the way we generally work around that in This is the help docs on
Does |
this good a idea! |
FIxes nvm-sh#2849. Co-authored-by: Martin <16228305+maartin0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
FIxes nvm-sh#2849. Co-authored-by: Martin <16228305+maartin0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
FIxes nvm-sh#2849. Co-authored-by: Martin <16228305+maartin0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
FIxes nvm-sh#2849. Co-authored-by: Martin <16228305+maartin0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
I second that |
FIxes nvm-sh#2849. Co-authored-by: Martin <16228305+maartin0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
FIxes nvm-sh#2849. Co-authored-by: Martin <16228305+maartin0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
As a heads up, the windows version of nvm does not support certain version strings the way that
Making it default might not work for users who use nvm for windows. |
BTW, there's direnv, here's a related issue: direnv/direnv#335 |
@katcaola you mean nvm-windows? That's a completely different project. nvm itself (which works on windows in some shells) supports the same strings as on non-windows. |
FIxes nvm-sh#2849. Co-authored-by: Martin <16228305+maartin0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <16228305+maartin0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Fixes nvm-sh#2849. Co-authored-by: Martin <maartin00000@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Thanks for the great work on this!
I am most familiar with a lot of the semantics of the
pyenv
project. One of the nice features that keeps things consistent is that whenpyenv
uses the following logic:.python_version
file in the current directory use that.python_version
in a parent directory, use that.python_version
in this or a parent directory, use the defaultpyenv local
pyenv local
is called, a.python_version
file is written to the current directoryI just learned that
nvm
supports the same via the.nvmrc
file. However, it is opt-in behavior (which I found surprising). I also found it hard to discover, because there was no command-line option related to writing a file / etc.And to the main thrust of this issue, the last bullet is different - I must write a
.nvmrc
file myself. I would expect that if I went to the trouble ofnvm use
in the current, then I am expecting other shells in this directory to do the same.Perhaps there is another use case I am not thinking of. However, at a minimum I would expect a flag to "write a
.nvmrc
file for me" as an opt-in. And the opt-out of writing such a file feels like the better interface.The text was updated successfully, but these errors were encountered: