Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD support #130

Closed
wants to merge 1 commit into from
Closed

FreeBSD support #130

wants to merge 1 commit into from

Conversation

voldern
Copy link

@voldern voldern commented Aug 9, 2012

FreeBSD ships with its own make program that is not compatible with the Node makefiles. This patch makes it use gmake when available.

@creationix
Copy link
Collaborator

Seems more like a patch for node itself? Also not everyone who has both gmake and make will prefer to use gmake.

@Suor
Copy link

Suor commented Nov 8, 2012

Still a workaround would be very desirable

@voldern
Copy link
Author

voldern commented Feb 12, 2013

My suggestion then is to check uname and if its FreeBSD use gmake. Does this sound like an acceptable solution?

@Suor
Copy link

Suor commented Feb 12, 2013

That should work. A better way is probably examining make itself, but I don't know how to do it. FreeBSDs make doesn't even have -v or --version option.

@voldern
Copy link
Author

voldern commented Feb 12, 2013

Yeah, unfortunately FreeBSD make doesn't seem to have a way to get the version. The only way I can come up with on the top of my head would be to check the capabilities of make by sending in a flag or something that is only supported in one of the makes, and then check the return code. But that seems to me like an uglier way then just checking uname.

I'll try to get some advice from more seasoned FreeBSD users.

@ljharb
Copy link
Member

ljharb commented Jun 14, 2013

This is absolutely a bug that should be filed against node, not against nvm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants