Fix nvm curl libz support #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Apr 6, 2017
nvm.sh
Outdated
| @@ -76,7 +76,7 @@ nvm_has_colors() { | |||
| } | |||
|
|
|||
| nvm_curl_libz_support() { | |||
| curl -V | grep "^Features:" | grep -q "libz" | |||
| curl -V 2>/dev/null | grep "^Features:" | grep -q "libz" | |||
There was a problem hiding this comment.
these greps should also probably be prefixed by command
There was a problem hiding this comment.
I use nvm_grep now.
PeterDaveHello
force-pushed
the
fix-nvm_curl_libz_support
branch
from
6ae43d9
to
519b74c
Compare
ljharb
approved these changes
Apr 6, 2017
ljharb
force-pushed
the
fix-nvm_curl_libz_support
branch
from
519b74c
to
daa9c36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my bad 馃槶
maybe we should consider to enable WITHOUT_CURL test back, what do you think?