Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Re-enable WITHOUT_CURL tests #1489

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

PeterDaveHello
Copy link
Collaborator

To prevent #1487 bug appears again.

@ljharb ljharb added the testing Stuff related to testing nvm itself. label Apr 6, 2017
@ljharb ljharb merged commit 2ec2d31 into nvm-sh:master Apr 7, 2017
@PeterDaveHello PeterDaveHello deleted the re-enable-WITHOUT_CURL-tests branch April 7, 2017 15:14
@PeterDaveHello
Copy link
Collaborator Author

wow the CI time seems to be doubled ... maybe we should test it another way, it's a little bit sad to see the time been doubled after i tried to reduce the time to half twice 😞

@PeterDaveHello
Copy link
Collaborator Author

PeterDaveHello commented Apr 9, 2017

The problem should be at every tests with TEST_SUITE=installation_node WITHOUT_CURL=1, it's strange that it seems to be not cached, 8 times slower vs TEST_SUITE=installation_node, @ljharb do you have any idea?

@PeterDaveHello
Copy link
Collaborator Author

Though I think it's nothing to do with nodejs itself, I still manually build nodejs v7.8.0 with/without curl, there is no time difference -

with curl:

real    4m20.452s
user    58m27.240s
sys     2m52.876s

without curl:

real    4m19.725s
user    58m26.844s
sys     2m52.728s

PeterDaveHello added a commit to PeterDaveHello/nvm that referenced this pull request Apr 9, 2017
@PeterDaveHello
Copy link
Collaborator Author

PeterDaveHello commented Apr 9, 2017

Okay, got the problem, it's not cached, PR sent #1496

@ljharb
Copy link
Member

ljharb commented Apr 9, 2017

It might be worth experimenting with the timing of the actual removal of curl - not sure tho, that seems weird.

@PeterDaveHello
Copy link
Collaborator Author

PeterDaveHello commented Apr 9, 2017

@ljharb nope, the removal takes few secs only, I'm still digging ... #1496 may not fix it.

@PeterDaveHello
Copy link
Collaborator Author

can't figure it out, maybe just see it it'll be fixed by its self ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Stuff related to testing nvm itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants