Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect latest release #1770

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Xaqron
Copy link

commented Apr 2, 2018

Due to constant change of version number it is bothering to update README file. Provided solution resolves this problem.

@ljharb
Copy link
Collaborator

left a comment

This is already automated by nvm's release process, so it's not actually bothersome.

I think having a version number in the command is helpful, to know what you're installing - and I think that curling to github's API is a bit of a brittle and convoluted approach (but I can't think of a better one)

@Xaqron

This comment has been minimized.

Copy link
Author

commented Apr 2, 2018

Better approach would be having the latest script at a constant address as openvpn or docker do.
Every time I gonna install node via NVM I should check what is the latest release so I guessed maybe this is a common problem to other people.

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Apr 2, 2018

That's by design; you should know what version of software you're installing and using, otherwise how can you know what features it has and what the API is?

@Xaqron

This comment has been minimized.

Copy link
Author

commented Apr 2, 2018

Exactly. The problem is with design according to best practices. Why big companies like openvpn and docker provide a static address for the latest stable release?
Currently any script trying to install latest NVM should be updated manually or by some code like I have provided in PR. Example of static URLs:

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Apr 2, 2018

Big companies do a lot of terrible things :-) the fact that a big company does something in no way automatically makes it a good practice.

I have http://latest.nvm.sh which redirects to https://github.com/creationix/nvm/releases/latest, but that's so you can get the manual install command you need from there, as a human.

@Xaqron

This comment has been minimized.

Copy link
Author

commented Apr 2, 2018

I appreciate your work. Just tried to make life easier :)
Q.E.D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.