-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clone depth #1846
base: master
Are you sure you want to change the base?
clone depth #1846
Conversation
probably don't need depth more than 1, sometimes takes a pretty long time to clone o/w
@@ -151,7 +151,7 @@ For a fully manual install, create a folder somewhere in your filesystem with th | |||
|
|||
```sh | |||
export NVM_DIR="$HOME/.nvm" && ( | |||
git clone https://github.com/creationix/nvm.git "$NVM_DIR" | |||
git clone --depth=1 https://github.com/creationix/nvm.git "$NVM_DIR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will drop the tags which means the following checkout
step will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to clone with depth
, then should use --branch
to specify the target tag/version, otherwise, this won't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per
#1846 (review)
any word on this bird? |
@ORESoftware some changes are still needed: #1846 (review) |
@ORESoftware are you still interested in completing this PR? |
c6cfc3a
to
c20db2a
Compare
probably don't need depth more than 1, sometimes takes a pretty long time to clone o/w