Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone depth #1846

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

clone depth #1846

wants to merge 1 commit into from

Conversation

ORESoftware
Copy link

probably don't need depth more than 1, sometimes takes a pretty long time to clone o/w

probably don't need depth more than 1, sometimes takes a pretty long time to clone o/w
@@ -151,7 +151,7 @@ For a fully manual install, create a folder somewhere in your filesystem with th

```sh
export NVM_DIR="$HOME/.nvm" && (
git clone https://github.com/creationix/nvm.git "$NVM_DIR"
git clone --depth=1 https://github.com/creationix/nvm.git "$NVM_DIR"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will drop the tags which means the following checkout step will fail.

Copy link
Collaborator

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to clone with depth, then should use --branch to specify the target tag/version, otherwise, this won't work.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ORESoftware
Copy link
Author

any word on this bird?

@ljharb
Copy link
Member

ljharb commented Oct 5, 2018

@ORESoftware some changes are still needed: #1846 (review)

@ljharb
Copy link
Member

ljharb commented Sep 28, 2019

@ORESoftware are you still interested in completing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants