Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone depth #1846

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ORESoftware
Copy link

commented Jun 22, 2018

probably don't need depth more than 1, sometimes takes a pretty long time to clone o/w

clone depth
probably don't need depth more than 1, sometimes takes a pretty long time to clone o/w
@@ -151,7 +151,7 @@ For a fully manual install, create a folder somewhere in your filesystem with th

```sh
export NVM_DIR="$HOME/.nvm" && (
git clone https://github.com/creationix/nvm.git "$NVM_DIR"
git clone --depth=1 https://github.com/creationix/nvm.git "$NVM_DIR"

This comment has been minimized.

Copy link
@PeterDaveHello

PeterDaveHello Jul 20, 2018

Contributor

This will drop the tags which means the following checkout step will fail.

@PeterDaveHello
Copy link
Contributor

left a comment

If we want to clone with depth, then should use --branch to specify the target tag/version, otherwise, this won't work.

@ljharb
Copy link
Collaborator

left a comment

@ORESoftware

This comment has been minimized.

Copy link
Author

commented Oct 4, 2018

any word on this bird?

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2018

@ORESoftware some changes are still needed: #1846 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.