[Fix] Add missing io.js installing message

[PeterDaveHello]

Fix #1988

[ljharb]

Thanks! It'd be nice to add a test for this tho, if possible.

[PeterDaveHello]

Is it really necessary to squash commits here? They are individually meaningful and not the totally same thing.

[ljharb]

How is the test commit meaningful, separate from the fix?

[PeterDaveHello]

It prevents the regression of the bug coming back, isn't it :)

[ljharb]

Sure, I see that as the same act as the fix itself - iow, it's not actually a fix if it doesn't include the regression test.

[PeterDaveHello]

So I'd like to try to add them in the same PR, but the same commit? I just prefer to make them separately.

[PeterDaveHello]

The test commit doesn't look meaningless to me.

Though I know the tests haven't passed yet 😅

[PeterDaveHello]

I'm still trying to fix that tests based on my local changes. So the commits will still be separately, if they are required to be squashed, maybe can do that once eveything is good.

[PeterDaveHello]

To make the case easier here, I'd like to just enable --no-progress for nvm install ... So I don't need to handle the progress bar which already has its own unit test.

[ljharb]

That seems totally reasonable!

[PeterDaveHello]

@ljharb looks like wget was not properly tested before, and its current output will contain timestamp, which makes the expected output in the tests harder to mock, can we just enable --quiet to disable its output?

[ljharb]

This test isn't testing the "fetching" output, using --quiet seems totally fine.

[PeterDaveHello]

I didn't mean just this test though, also fine?

[PeterDaveHello]

The current wget output is like this:

$ wget -c https://iojs.org/dist/v1.0.0/iojs-v1.0.0-linux-x64.tar.xz -nv
2019-01-23 15:47:16 URL:https://iojs.org/dist/v1.0.0/iojs-v1.0.0-linux-x64.tar.xz [5325772/5325772] -> "iojs-v1.0.0-linux-x64.tar.xz" [1]

[ljharb]

Maybe we can head 1 it? I'm only interested in testing Downloading and installing io.js v1.0.0...

[PeterDaveHello]

I'm fine with that.

[PeterDaveHello]

I guess head will cut off the progress of the installation, so will use a trick to wait for the whole process properly finished.