Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] git install document update, sourcing nvm #2205

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

huahuayu
Copy link
Contributor

please refer to the issue #2204

README.md Outdated
Comment on lines 172 to 173
2. `cd ~/.nvm` and check out the latest version with `git checkout v0.35.3`
3. activate `nvm` by sourcing it from your shell: `. ./nvm.sh`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. `cd ~/.nvm` and check out the latest version with `git checkout v0.35.3`
3. activate `nvm` by sourcing it from your shell: `. ./nvm.sh`
1. `cd ~/.nvm` and check out the latest version with `git checkout v0.35.3`
1. activate `nvm` by sourcing it from your shell: `. ./nvm.sh`

using 1 for every item makes the numbering automatic.

@ljharb ljharb added informational installing nvm Problems installing nvm itself needs followup We need some info or action from whoever filed this issue/PR. labels May 4, 2020
@ljharb
Copy link
Member

ljharb commented Aug 10, 2020

@huahuayu this is still waiting for you to update the PR to resolve the issue i mentioned; are you still interested in completing the PR?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went ahead and made the change.

@ljharb ljharb merged commit 10399ed into nvm-sh:master Dec 28, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
informational installing nvm Problems installing nvm itself needs followup We need some info or action from whoever filed this issue/PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants