Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak build with libc++ < 11 #187

Merged
merged 1 commit into from Sep 26, 2021
Merged

Unbreak build with libc++ < 11 #187

merged 1 commit into from Sep 26, 2021

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Sep 25, 2021

Found on FreeBSD 11.4/12.2. Later versions (CI uses FreeBSD 13.0) are not affected as <errno.h> is bootlegged via <string> in common/nwg_exceptions.h

common/nwg_exceptions.cc:16:5: error: use of undeclared identifier 'errno'
    errno = 0;
    ^
common/nwg_exceptions.cc:18:18: error: use of undeclared identifier 'errno'
    if (!cstr || errno) {
                 ^
Copy link
Collaborator

@Siborgium Siborgium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@Siborgium Siborgium merged commit f916cd4 into nwg-piotr:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants