Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode for nwggrid, a bit of refactoring #78

Merged
merged 7 commits into from Aug 6, 2020
Merged

Unicode for nwggrid, a bit of refactoring #78

merged 7 commits into from Aug 6, 2020

Conversation

Siborgium
Copy link
Collaborator

No description provided.

@Siborgium
Since InputParser uses std::string_view, we don't need
97e12b1 
  `empty_string` field anymore
Use `take_last_by` instead of `split_string` in `dmenu/dmenu.cc`
@Siborgium
nwggrid:
d315075 
  Override default handlers instead of connecting new signals
  Freeze/thaw grids when inserting apps
  Use `grab_focus` instead of `set_property`
nwgbar:
  Override default handler instead of connecting a signal
  Freeze/thaw grid when inserting apps
  BarEntry constructor now receives args by-value
  Move BarEntry constructor `bar/bar_tools.cc` -> `bar/bar_classes.cc`
@Siborgium
Obtain icon theme once
a0cd408 
Rewrite icon loading
Fix highlighting not appearing
@Siborgium
Change forgotten set_property -> grab_focus
c88a660 
Use `{freeze,thaw}_child_notify` when rebuilding grid
@Siborgium
Use Gtk's placeholder text instead of artificial
1a09c97 
Only handle necessary keys, pass others into search entry
Use casefold instead of uppercase for string comparison
@Siborgium
nwgbar:
a7e02ed 
  Fix nwgbar not launching apps
`take_last_by`:
  Add missing return
  Fix incorrect index
@nwg-piotr
Copy link
Owner

I was working on the grid search box last night on another branch, but probably your solution is better. Will take a closer look at home.

@Siborgium
Copy link
Collaborator Author

Oh, sorry about that. Feel free to ask questions, I'd be glad to have my code reviewed. Don't merge yet, I've noticed that the SearchEntry omits space for some reason.
Also, I would like to dig into icons loading in the next few days, is it ok?

@nwg-piotr
Copy link
Owner

nwg-piotr commented Aug 5, 2020 •
edited

Whatever is going to be done soon, should be finished till the end of this week. Later I'm off for lakes (11 days).

@nwg-piotr
Copy link
Owner

SearchEntry omits space for some reason

Looks as if Gtk::SearchEntry::handle_event didn't handle GDK_KEY_space.

@Siborgium
nwggrid:
07fa861 
  Fix searchbox omitting space
  Call `filter_view` on `signal_search_changed`, not all insertions
  Replace deprecated Gtk::Main with recommended Gtk::Application
  Remove obsolete `search_phrase` field
  Remove unused functions
@Siborgium
Copy link
Collaborator Author

Well, since it seems to work, I'd believe it's finished.
I was unable to speed up icon loading, the only open possibility is to use asynchronous loading which is hard to incorporate. I see no reason to rewrite already working functionality either. As such, I won't be pushing commits anytime soon.
Thank you for your work, these applications are really nice to use. I am glad I was able to improve them.

@nwg-piotr
Copy link
Owner

As I see, it was quite tricky to make the space key work. :)

What seems to speed up icons loading most is the icon theme. Replacing Adwaita with Papirus speed it up in the way visible to naked eye.

After merging your PR, I'll publish a release on Saturday or Sunday, if testing goes well. Then I'm having a brake, as mentioned above. Thank you very much for your contribution.

@nwg-piotr nwg-piotr merged commit dbdfa2a into nwg-piotr:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Siborgium @nwg-piotr