Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode for nwggrid, a bit of refactoring #78

Merged
merged 7 commits into from
Aug 6, 2020

Commits on Aug 5, 2020

  1. Since InputParser uses std::string_view, we don't need

      `empty_string` field anymore
    Use `take_last_by` instead of `split_string` in `dmenu/dmenu.cc`
    Siborgium committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    97e12b1 View commit details
    Browse the repository at this point in the history
  2. nwggrid:

      Override default handlers instead of connecting new signals
      Freeze/thaw grids when inserting apps
      Use `grab_focus` instead of `set_property`
    nwgbar:
      Override default handler instead of connecting a signal
      Freeze/thaw grid when inserting apps
      BarEntry constructor now receives args by-value
      Move BarEntry constructor `bar/bar_tools.cc` -> `bar/bar_classes.cc`
    Siborgium committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    d315075 View commit details
    Browse the repository at this point in the history
  3. Obtain icon theme once

    Rewrite icon loading
    Fix highlighting not appearing
    Siborgium committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    a0cd408 View commit details
    Browse the repository at this point in the history
  4. Change forgotten set_property -> grab_focus

    Use `{freeze,thaw}_child_notify` when rebuilding grid
    Siborgium committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    c88a660 View commit details
    Browse the repository at this point in the history
  5. Use Gtk's placeholder text instead of artificial

    Only handle necessary keys, pass others into search entry
    Use casefold instead of uppercase for string comparison
    Siborgium committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    1a09c97 View commit details
    Browse the repository at this point in the history
  6. nwgbar:

      Fix nwgbar not launching apps
    `take_last_by`:
      Add missing return
      Fix incorrect index
    Siborgium committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    a7e02ed View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. nwggrid:

      Fix searchbox omitting space
      Call `filter_view` on `signal_search_changed`, not all insertions
      Replace deprecated Gtk::Main with recommended Gtk::Application
      Remove obsolete `search_phrase` field
      Remove unused functions
    Siborgium committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    07fa861 View commit details
    Browse the repository at this point in the history