Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig refresh #10

Merged
merged 6 commits into from
Jan 7, 2022
Merged

Add sig refresh #10

merged 6 commits into from
Jan 7, 2022

Conversation

hillyu
Copy link

@hillyu hillyu commented Dec 25, 2021

it would be useful to add custom signals for script refresh so the script can be triggered by signals instead of constantly polling/refreshing. This is useful for things like album cover update on music player's track/status changes.
By the way, do you guys think using real-time signal would be better? i.e. RTMIN+No. Think those status bars mostly use that for triggering update.

@nwg-piotr
Copy link
Owner

Sorry for the late reply.

I'm working hard on integration of all the nwg-shell stuff in a real shell, for use with ArchLabs Linux. Wouldn't like to make changes before I'm adding the wrapper, which should happen soon. I'll get back to your PR as soon as I can.

@hillyu
Copy link
Author

hillyu commented Dec 29, 2021

sure thing, no worries, I made a few more changes here. Including making the anchor for top/bottom checking align and anchor to one at a time, instead of anchor to both top and bottom at the same time, old way would make aligning multiple widget a real pain. Take your time and really like this project, I made some really good looking yet practical dashboards with it :D keep up the good work!
image

whatever change I made will be updated here: https://github.com/hillyu/nwg-wrapper/tree/dev.

@nwg-piotr
Copy link
Owner

It looks very well. Would you mind contributing some of your work, e.g. to the examples folder?

@hillyu
Copy link
Author

hillyu commented Dec 31, 2021

Will do. It's still a work in progress and I will certainly contribute once they are ready.

@nwg-piotr
Copy link
Owner

nwg-piotr commented Dec 31, 2021

Thanks in advance!

Funny thing: this is just a simple script, which I wrote in one evening, on request of some guy on reddit. Good thing it turns out useful to more people.

@hillyu
Copy link
Author

hillyu commented Jan 4, 2022

#11 selected a few script I did as an example.

@nwg-piotr
Copy link
Owner

Thank you! I have a few days off starting from tomorrow. Will review/merge your work.

@nwg-piotr nwg-piotr merged commit 263c616 into nwg-piotr:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants