Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gopherjs compilation fails #18

Closed
nubunto opened this issue Jul 3, 2015 · 5 comments
Closed

Gopherjs compilation fails #18

nubunto opened this issue Jul 3, 2015 · 5 comments

Comments

@nubunto
Copy link

nubunto commented Jul 3, 2015

Trying to build Nintengo with gopherjs build -m gives me this error:

../../../../../go/src/testing/testing.go:614:13: StartTrace not declared by package pprof
../../../../../go/src/testing/testing.go:636:3: StopTrace not declared by package pprof

I'm running Go 1.5 from the master branch, version +64e48bb, on a Lubuntu x64 machine.

@nwidger
Copy link
Owner

nwidger commented Jul 3, 2015

I just tested and nintengo builds fine with the latest GopherJS and Go 1.4.2. I haven't actually tried building nintengo (via GopherJS or a normal build) with Go 1.5 at all yet since it hasn't been released. Not sure if the issue you're seeing is specific to nintengo or a GopherJS/Go 1.5 issue. I'd be okay waiting to see if this is still an issue after Go 1.5 is officially out. Thanks for reporting this, though!

@nubunto
Copy link
Author

nubunto commented Jul 3, 2015

Yes, initially I thought it could be an Go 1.5 issue, but hadn't tested compiling with a stable version. Just tried now and it works fine. I wonder what goes wrong with Go 1.5 though.

@nwidger
Copy link
Owner

nwidger commented Jul 4, 2015

Not sure, but I definitely plan to check in once Go 1.5 is out and see how things are then.

@nwidger nwidger closed this as completed Jul 4, 2015
@slimsag
Copy link
Contributor

slimsag commented Jul 4, 2015

GopherJS has to be updated with each Go release to handle certain internal stdlib changes, I think. It probably only supports Go 1.4.2 right now.

/cc @neelance

@neelance
Copy link

neelance commented Jul 5, 2015

Yes, currently only 1.4.2 is supported. I will start an 1.5 branch soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants