Skip to content

Commit

Permalink
Fix lighthouse crash
Browse files Browse the repository at this point in the history
  • Loading branch information
rogerwang committed Jan 31, 2021
1 parent ccce7f3 commit 3004242
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions content/browser/renderer_host/render_frame_host_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8376,8 +8376,10 @@ bool RenderFrameHostImpl::ValidateDidCommitParams(

// Commits in the error page process must only be failures, otherwise
// successful navigations could commit documents from origins different
// than the chrome-error://chromewebdata/ one and violate expectations.
if (should_commit_unreachable_url && !params->url_is_unreachable) {
// than the chrome-error://chromewebdata/ one and violate
// expectations.
// NWJS: different process model where the pages are in the same process
if (false && should_commit_unreachable_url && !params->url_is_unreachable) {
DEBUG_ALIAS_FOR_ORIGIN(origin_debug_alias, params->origin);
bad_message::ReceivedBadMessage(
process, bad_message::RFH_ERROR_PROCESS_NON_ERROR_COMMIT);
Expand Down

0 comments on commit 3004242

Please sign in to comment.