Skip to content

Commit

Permalink
It2Me Native Messaging Host crash
Browse files Browse the repository at this point in the history
This is a regression caused by the recent migration to SimpleUrlLoader:
https://chromium-review.googlesource.com/1194042

I had thought all of our binaries now had the correct Mojo dependencies
added but it looks like the NMH binary was missed.

Bug: 879593
Change-Id: I2858524d1d78abce45e7a6a34a8739ad47320a5e
Reviewed-on: https://chromium-review.googlesource.com/1199705
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588068}(cherry picked from commit 82548bb)
Reviewed-on: https://chromium-review.googlesource.com/1204431
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#25}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
  • Loading branch information
Joe Downing committed Sep 4, 2018
1 parent 469b43d commit 347a697
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions remoting/host/it2me/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ source_set("common") {

deps = [
"//base:i18n",
"//mojo/core/embedder",
"//net",
"//remoting/base",
"//remoting/host",
Expand Down
3 changes: 3 additions & 0 deletions remoting/host/it2me/it2me_native_messaging_host_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include "base/run_loop.h"
#include "base/task/task_scheduler/task_scheduler.h"
#include "build/build_config.h"
#include "mojo/core/embedder/embedder.h"
#include "remoting/base/auto_thread_task_runner.h"
#include "remoting/base/breakpad.h"
#include "remoting/host/chromoting_host_context.h"
Expand Down Expand Up @@ -98,6 +99,8 @@ int It2MeNativeMessagingHostMain(int argc, char** argv) {
// Required to find the ICU data file, used by some file_util routines.
base::i18n::InitializeICU();

mojo::core::Init();

base::TaskScheduler::CreateAndStartWithDefaultParams("It2Me");

remoting::LoadResources("");
Expand Down

0 comments on commit 347a697

Please sign in to comment.