Fix: Chrome-like User-Agent in some requests #25

janRucka · 2016-06-06T10:08:23Z

…ent was sometimes used.

…ements. In, particular, the following issues: 1. Paint invalidation missed cases when elements had "intrinsic scrollability", in particular input elements. 2. Invalidation of carets incorrectly included scrolling for composited input elements. 3. The DisplayItemClient must be distinct for case #2, because it paints into a different GraphicsLayer than the rest of the LayoutBlock. BUG=635724 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2271883002 Cr-Commit-Position: refs/heads/master@{#415013} (cherry picked from commit b1d694f) Review URL: https://codereview.chromium.org/2291793003 . Cr-Commit-Position: refs/branch-heads/2840@{#25} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

"PasswordManager.GetUnmediated" tracks the result of the call when a site wants the auto sign-in behavior. "PasswordManager.GetMediated" is recorded when a site would like to bring the account chooser. The user can still be auto signed in in that case. BUG=529303 Review-Url: https://codereview.chromium.org/2505073002 Cr-Commit-Position: refs/heads/master@{#433185} (cherry picked from commit 4d26f81) Review URL: https://codereview.chromium.org/2521583002 . Cr-Commit-Position: refs/branch-heads/2924@{#25} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

As a result of my previous changes to this code, there appeared a race condition where finishNativeInitialization() could be called before onFlowIsKnown() is called. This would either cause sign-in & data reduction pages to simply not be created or could also cause a crash if mFreProperties were restored from a previous run. This CL fixes both of the above issues. If native init happens before onFlowIsKnown, the code will defer creating the extra pages & skipping them to onFlowIsKnown() in the future - which actually matches to how the code was structured originally. BUG=683048 Review-Url: https://codereview.chromium.org/2647763006 Cr-Commit-Position: refs/heads/master@{#445134} (cherry picked from commit 3a70e43) Review-Url: https://codereview.chromium.org/2652743002 . Cr-Commit-Position: refs/branch-heads/2987@{#25} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

BUG=698301 Review-Url: https://codereview.chromium.org/2732473005 Cr-Commit-Position: refs/heads/master@{#454725} (cherry picked from commit 780787a) Review-Url: https://codereview.chromium.org/2734783003 . Cr-Commit-Position: refs/branch-heads/3029@{#25} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

1) Elements with hidden attributes 2) Hidden form elements We orginally tried to act more aggresively by skipping all possible hidden elements. But this does break certain web sites that uses nth CSS selectors. BUG=697970 TEST=tests updated TBR=svaldez@chromium.org Review-Url: https://codereview.chromium.org/2819723003 Cr-Commit-Position: refs/heads/master@{#464856} (cherry picked from commit 2ddf990) Review-Url: https://codereview.chromium.org/2826533002 . Cr-Commit-Position: refs/branch-heads/3071@{#25} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

This reverts commit 0692c33. TBR=govind BUG=748360 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie25c9778889b7fa31a74a8a592a54d8e881a89d3 Reviewed-on: https://chromium-review.googlesource.com/584815 Reviewed-by: Alex Mineer <amineer@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#25} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

Both MediaControlsOrientationLockDelegate and MediaControlsRotateToFullscreenDelegate would incorrectly call ToDeviceOrientationEvent on synthetic events created by the webpage whose type name was "deviceorientation", even if they weren't instances of DeviceOrientationEvent. This patch fixes that. It also checks that the events are trusted, to avoid using deviceorientation values synthesized by the webpage (other event listeners in these classes don't use values from the event object, so it's less important for them to be trusted). TBR=johnme@chromium.org (cherry picked from commit cd76873) Bug: 761613,760737 Change-Id: I318d10e3b6dd84277a47b06546fd4c3ebcdb03cb Reviewed-on: https://chromium-review.googlesource.com/647929 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499515} Reviewed-on: https://chromium-review.googlesource.com/650728 Reviewed-by: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#25} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

screenshot: https://drive.google.com/file/d/0B1dtd3IUt4I7TzFkTzJWRmNRVk0 Bug: 774194 Change-Id: I914e672b57c8f305b1e4c4a05e519b272bfb3528 Reviewed-on: https://chromium-review.googlesource.com/716438 Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by: Ramya Sharma <ramyasharma@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508583}(cherry picked from commit bca67b1) Reviewed-on: https://chromium-review.googlesource.com/722540 Reviewed-by: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#25} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

…Web browsing in Public Sessions TBR=isandrk@chromium.org (cherry picked from commit 4c08568) Bug: chromium:572103, chromium:803531 Change-Id: I02dcc1636f20991f9ad3e0f2be78b3c506810e67 Reviewed-on: https://chromium-review.googlesource.com/874451 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530515} Reviewed-on: https://chromium-review.googlesource.com/880585 Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#25} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

Reference to a WeakPtr was to a WeakPtr that was deleted in certain cases. Fixed by just making a copy. Bug: 817866 Change-Id: I9fae68d018c4178a8224b3e79ab44c8a1282be87 Reviewed-on: https://chromium-review.googlesource.com/943983 Reviewed-by: Bence Béky <bnc@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540305}(cherry picked from commit f5e3b1b) Reviewed-on: https://chromium-review.googlesource.com/950382 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#25} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

…isconnected _session is only valid when the session is connected. This CL adds tests before using _session in RemotingClient. Bug: 831954 Change-Id: I0f12221f2c80b55d0a784dc8771fbec573fd1deb Reviewed-on: https://chromium-review.googlesource.com/1010917 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550438}(cherry picked from commit 6a647c7) Reviewed-on: https://chromium-review.googlesource.com/1012791 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#25} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

This is required on Chrome OS ARM platforms to allocate BLOB buffers for camera HAL. BUG=845536, 832772 TEST=Make sure camera works on Dru. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I656f7166663192c255989b68f985943eeb2d8b64 Reviewed-on: https://chromium-review.googlesource.com/1073186 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562319}(cherry picked from commit 12741be) Reviewed-on: https://chromium-review.googlesource.com/1076847 Reviewed-by: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#25} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

This Cl fixes issue with <oobe-back-button> and <oobe-next-button> when text styling was not applied to <slot> default values. TBR=alemate@chromium.org (cherry picked from commit e9e5127) Bug: 865907 Change-Id: I035e0c9144527a84c6865f6fae3d86d34272c169 Reviewed-on: https://chromium-review.googlesource.com/1145870 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577054} Reviewed-on: https://chromium-review.googlesource.com/1147332 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#25} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

This is a regression caused by the recent migration to SimpleUrlLoader: https://chromium-review.googlesource.com/1194042 I had thought all of our binaries now had the correct Mojo dependencies added but it looks like the NMH binary was missed. Bug: 879593 Change-Id: I2858524d1d78abce45e7a6a34a8739ad47320a5e Reviewed-on: https://chromium-review.googlesource.com/1199705 Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588068}(cherry picked from commit 82548bb) Reviewed-on: https://chromium-review.googlesource.com/1204431 Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#25} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

This reverts commit ffea867. Reason for revert: The WebRTC M71 branch has been fixed, so re-pin to it. Tested OK locally syncing deps and building with this revert. Here's the fixed WebRTC M71 branch: https://webrtc.googlesource.com/src/+log/branch-heads/71 Original change's description: > Revert webrtc unpinning. > > Speculative fix that the webrtc m71 branch is out-of-sync with src.git > and the cause of build failures. > > R=govind@google.com, tommi@google.com > > Bug: 895012 > Change-Id: Ibd19f2371b6eda5d915ce4ebf9ba377e507ff0c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1279345 > Reviewed-by: Krishna Govind <govind@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#6} > Cr-Branched-From: 4226ddf-refs/heads/master@{#599034} TBR=tommi@chromium.org,mmoss@chromium.org,govind@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 895012 Change-Id: I4fe1be11eb845e36f752d05687bb7acf7af2b267 Reviewed-on: https://chromium-review.googlesource.com/c/1280666 Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#25} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

Remove consent bump internals. This includes: - API + tests from UnifiedConsentService - Metrics - Feature state and flags (cherry picked from commit 460a586) Bug: 906026 Change-Id: Ibc12bee6ea661061530e321fe9c9e45363792f9d Reviewed-on: https://chromium-review.googlesource.com/c/1355162 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612621} Reviewed-on: https://chromium-review.googlesource.com/c/1361240 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#25} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

Currently, if a device starts a RemotePlayback session and an external device plays/pauses the video (via the Android cast notification), the WMPI that started the casting session never gets updated. This means that the user will see the video element on their phone as "playing", with no media time update, or they will see the local video as paused when the cast video is clearly playing. This CL addresses the issue by requesting Blink to play/pause the HTMLMediaElement to match the state of the remotely playing video. This is done by bubbling up play state changes from the FlingingRenderer to WMPI via the OnRemotePlayStateChange interface. To detect an external play state change, we save whether the last command from WMPI was a play or a pause, and propagate a change whenever we get a MediaStatus update that is of the opposite play state. The cast device does not care if it receives a "PLAY" command while already playing (or "PAUSE" when paused). Therefore, after calling OnRemotePlayStateChange, FlingingRenderer does not need to treat the commands it receives any differently than a user initiated command. NOTE: This approach works reasonably well, but is not an ironclad guarantee of consistency. We are fine with missing a few changes, because all the user has to do is tap the video element once to return to a consistent state. Being too aggressive in trying to detect play state changes sometimes causes the phone to go in a feedback loop, where it constantly issues commands while the UI wildly switches between playing and pausing. Bug: 790766, 925576 Change-Id: If230c412a6a020c88970e1c9475d8fdc97976c3b Reviewed-on: https://chromium-review.googlesource.com/c/1413398 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626188}(cherry picked from commit 9f575d2) Reviewed-on: https://chromium-review.googlesource.com/c/1440205 Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#25} Cr-Branched-From: e510299-refs/heads/master@{#625896}

R=benmason@chromium.org Change-Id: I62295c0fc90e52ead0a949ba073590b5b89e4228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516290 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#25} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

rogerwang and others added 2 commits June 6, 2016 11:04

nwjs master

9806d6b

Now custom User-Agent (if exists) is always used. Chrome-like User Ag…

75787cb

…ent was sometimes used.

janRucka mentioned this pull request Jun 6, 2016

Chrome-like User-Agent in some requests nwjs/nw.js#4935

Open

rogerwang force-pushed the nw14 branch 5 times, most recently from 03c9b12 to f846851 Compare June 13, 2016 11:16

rogerwang force-pushed the nw14 branch 3 times, most recently from 64fe72c to a215279 Compare June 26, 2016 08:36

rogerwang force-pushed the nw14 branch 2 times, most recently from 954e187 to c661222 Compare July 22, 2016 00:36

rogerwang force-pushed the nw14 branch from c661222 to 4e17801 Compare March 6, 2017 09:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Chrome-like User-Agent in some requests #25

Fix: Chrome-like User-Agent in some requests #25

janRucka commented Jun 6, 2016

Fix: Chrome-like User-Agent in some requests #25

Are you sure you want to change the base?

Fix: Chrome-like User-Agent in some requests #25

Conversation

janRucka commented Jun 6, 2016