Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use correct sysroot when building node #52

Closed
wants to merge 6 commits into from
Closed

build: use correct sysroot when building node #52

wants to merge 6 commits into from

Conversation

ayushmanchhabra
Copy link
Contributor

@ayushmanchhabra ayushmanchhabra commented Mar 3, 2023 •
edited
Loading

Fixes: #16
Fixes: #46

@ayushmanchhabra ayushmanchhabra mentioned this pull request Mar 3, 2023
Closed
@ayushmanchhabra ayushmanchhabra changed the title Fix error when generating Node build files build: resolve error when generating Node build files Mar 4, 2023
This was referenced Mar 4, 2023
Closed
Closed
@ayushmanchhabra ayushmanchhabra changed the title build: resolve error when generating Node build files build: use correct sysroot when building node Mar 6, 2023
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review March 7, 2023 08:36
@ayushmanchhabra ayushmanchhabra marked this pull request as draft March 10, 2023 02:37
@ayushmanchhabra ayushmanchhabra changed the base branch from nw73 to nw74 March 10, 2023 02:41
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review March 15, 2023 05:59
@ayushmanchhabra
Copy link
Contributor Author

Superceded by #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ayushmanchhabra