Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_instance does not create new renderer process #5163

Closed
ghost opened this issue Jul 28, 2016 · 3 comments
Closed

new_instance does not create new renderer process #5163

ghost opened this issue Jul 28, 2016 · 3 comments
Assignees
@ghostoy
Labels
regression

Comments

@ghost
Copy link

ghost commented Jul 28, 2016 •
edited by ghost

I've had a problem since sometime in 0.13 with new_instance on nw.Window.open not actually spawning a new renderer process. This did appear to work at some point between 0.12 and 0.13 but I forget which build. I am on Windows 8.1 (x64) using nwjs 0.16.0 SDK.

Here is my demo:

package.json

{
  "name": "NW Test",
  "main": "./demo.js",
  "description": "test",
  "version": "1.0.0",
  "node-remote": "<all_urls>"
}

demo.js

(function(){
    nw.Window.open('./demo.htm', {
            'id': 'window1'
        }, function(win){
            nw.Window.open('./demo.htm', {
                    'id': 'window2',
                    'new_instance': true
                }, function(win2){}
            );
            nw.Window.open('./demo.htm', {
                    'id': 'window3',
                    'new_instance': true
                }, function(win2){}
            );
    });
})();

demo.htm

<html>
<head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
</head>
<body>
Testing
</body>
</html>

And here is what I see in my task manager.
demo

Now perhaps I am reading something wrong or missing something. But any insight would be very helpful!
ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Aug 5, 2016
[test] test case for nwjs#5163
4fef9f7
ghostoy pushed a commit to ghostoy/chromium.src that referenced this issue Aug 5, 2016
create new SiteInstance when using new_instance
a0aa609 
fixed nwjs/nw.js#5163
@ghostoy ghostoy mentioned this issue Aug 5, 2016
Open
rogerwang added a commit that referenced this issue Aug 22, 2016
@rogerwang
Merge pull request #5192 from ghostoy/issue-5163-test
b4f50b1 
[test] test case for #5163
ghostoy pushed a commit to ghostoy/chromium.src that referenced this issue Aug 23, 2016
create new SiteInstance when using new_instance
abad72d 
fixed nwjs/nw.js#5163
@ghostoy ghostoy mentioned this issue Aug 23, 2016
Closed
rogerwang pushed a commit that referenced this issue Aug 24, 2016
@rogerwang
[test] test case for #5163
becb87c
@rogerwang
Copy link
Member

fixed in http://dl.nwjs.io/live-build/08-24-2016/nw17-ff103c3-2487fce-de19b1f-6c79a25/v0.17.0-rc1/

@xuanhun
Copy link

xuanhun commented Aug 29, 2016

When to release nw17?

@rogerwang
Copy link
Member

@xuanhun it will be released in 1-2 days after Chromium 53 stable is released. Hopefully before Sep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghostoy ghostoy

Labels
regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rogerwang @ghostoy @xuanhun