Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create new SiteInstance when using new_instance #41

Closed
wants to merge 3 commits into from
Closed

create new SiteInstance when using new_instance #41

wants to merge 3 commits into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Aug 23, 2016

@rogerwang
Copy link
Member

We need to check whether this fails nwjs/nw.js#4691 because there is no test for that case.

@ghostoy
Copy link
Member Author

ghostoy commented Aug 24, 2016

@rogerwang It doesn't regress that issue. I will submit a test case for it.

@rogerwang
Copy link
Member

Thanks. It's merged.

@rogerwang rogerwang closed this Aug 24, 2016
rogerwang pushed a commit that referenced this pull request Sep 7, 2016
@adrifelt
Merge Downgrade security state after user clicks through SB interstitial
82e2925 
BUG=615123
TEST=
1. Go to the following URLs in different tabs:
   http://ianfette.org
   http://parkerly.com/sb-tests/bad-subresources.html
   https://parkerly.com/sb-tests/bad-subresources.html
2. Click through the warnings that appear
3. Verify that the omnibox security indicator shows a red triangle

Review-Url: https://codereview.chromium.org/2270283002
Cr-Commit-Position: refs/heads/master@{#414638}
(cherry picked from commit 6b00a3a)

Review URL: https://codereview.chromium.org/2289233002 .

Cr-Commit-Position: refs/branch-heads/2840@{#41}
Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}
rogerwang pushed a commit that referenced this pull request Dec 5, 2016
Show brightness change when system menu is open
73469a6 
When the system menu is open but does not contain the brightness row,
changing the brightness using keyboard should close the system menu and
show the brightness popup.

BUG=666914
TEST=manual

Review-Url: https://codereview.chromium.org/2512293002
Cr-Commit-Position: refs/heads/master@{#433380}
(cherry picked from commit 878e1e6)

Review URL: https://codereview.chromium.org/2513413005 .

Cr-Commit-Position: refs/branch-heads/2924@{#41}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
@wangxianzhu
Add runtime feature SlimmingPaintInvalidation
82c51e9 
This is disbled by default for M57.

Will switch to enabled by default when we enable
SlimmingPaintInvalidation feature in blink on M58.

BUG=646176
R=esprehn@chromium.org
TBR=jochen@chromium.org (content/child/runtime_features.cc: chrome feature->blink feature)
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2647883004
Cr-Original-Commit-Position: refs/heads/master@{#445220}
Review-Url: https://codereview.chromium.org/2648173004
Cr-Commit-Position: refs/branch-heads/2987@{#41}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@asvitkine-chromium
Fix UKM crash. Add TODO for fixing this properly.
cdd9e75 
BUG=698819,695433

Review-Url: https://codereview.chromium.org/2736733004
Cr-Commit-Position: refs/heads/master@{#454998}
(cherry picked from commit c881190)

Review-Url: https://codereview.chromium.org/2735153003 .
Cr-Commit-Position: refs/branch-heads/3029@{#41}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
@ishermandom
[Android Crash Reporting] Fix a null pointer dereference.
077fa8d 
The MinidumpDirectoryObserver's onEvent callback might be called with a null
path. Don't crash in this case.

BUG=711404
R=mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2822763003
Cr-Commit-Position: refs/heads/master@{#465084}
(cherry picked from commit b87bf58)

Review-Url: https://codereview.chromium.org/2830493002 .
Cr-Commit-Position: refs/branch-heads/3071@{#41}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Tether: Always scan for hosts when requested by UI.
94a8ccb 
Tether previously gated scans to once per 5 minutes. This CL
removes that gating mechanism.

TBR=hansberry@chromium.org

(cherry picked from commit 33966bd)

Bug: 745160, 672263
Change-Id: I254c2dda302f4caecdef68974d26cec3babe3fa5
Reviewed-on: https://chromium-review.googlesource.com/578255
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489069}
Reviewed-on: https://chromium-review.googlesource.com/584865
Cr-Commit-Position: refs/branch-heads/3163@{#41}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
@folded
Disable ScrollTopLeftInterop in WebView.
4fee1fa 
Applications depend on the current behaviour for layout, and may not be
able to update in time to avoid regressions for users.

BUG=761016
TBR=tobiasjs@google.com

(cherry picked from commit 416174f)

Change-Id: Id7153a62fe1e3a550a049e4b2a6b9a57e6f7891d
Reviewed-on: https://chromium-review.googlesource.com/645980
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499101}
Reviewed-on: https://chromium-review.googlesource.com/652546
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#41}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
Incrementing VERSION to 63.0.3239.10
f6ebf0b 
TBR=dimu@chromium.org

Change-Id: Ia184a4add1b467e928021b5a16d34af9e17601e1
Reviewed-on: https://chromium-review.googlesource.com/724599
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#41}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@stevenjb
Fix network config focus issues
14c9b21 
* Correctly focuses SSID or passphrase field
* Correctly enables 'connect' button as soon as valid input is typed
* Defaults 'Connect' button to disabled to avoid initial blink
* Sizes the dialog correctly when just a passphrase is required
* Uses the new dialogs correctly from the 'Network not available'
  screen in login/oobe.

TBR=stevenjb@chromium.org

(cherry picked from commit cb02c82)

Bug: 795718,797891
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie81d3c16db56d8a0c020da3e001f9118b638974b
Reviewed-on: https://chromium-review.googlesource.com/869116
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530564}
Reviewed-on: https://chromium-review.googlesource.com/882185
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#41}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
@plmonette-zz
Adding the HasAdminRights function
57b0d8d 
Let us determine if the user is able to elevate without a password.

Bug: 717696
Change-Id: I8e5fa4e8de348eac32cd27a046840930d7f5dff8
Reviewed-on: https://chromium-review.googlesource.com/927356
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540952}(cherry picked from commit a725653)
Reviewed-on: https://chromium-review.googlesource.com/952043
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#41}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Making RepostFormWarningDialog shows up in VR
23a75c1 
Note that it depends on https://chromium-review.googlesource.com/c/chromium/src/+/1010479

This CL replaces the support library's AlertDialog with a VrAlertDialog IFF we are
in VR.


TBR=bshe@chromium.org

(cherry picked from commit 14a6d4d)

Bug: 831233
Change-Id: I4ef0586625e3ae447f55b1e6045f2fb2dfef09ff
Reviewed-on: https://chromium-review.googlesource.com/1010916
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550431}
Reviewed-on: https://chromium-review.googlesource.com/1014717
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#41}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
[Payments] Return correct result for CanMakePayment in incognito mode
dec482b 
Bug: 846698
Change-Id: I30854784b6f3aa4c8f430884a40c373b1da878e0
Reviewed-on: https://chromium-review.googlesource.com/1073873
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562270}(cherry picked from commit f403644)
Reviewed-on: https://chromium-review.googlesource.com/1078451
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#41}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
@clelland
Make Feature Policy JS API an Origin Trial
7e67004 
TBR=iclelland@chromium.org

(cherry picked from commit 6662b3a)

Bug: 703703
Change-Id: I4ab576d16835e13ad618e4e2794132be1a80f845
Reviewed-on: https://chromium-review.googlesource.com/1144274
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576999}
Reviewed-on: https://chromium-review.googlesource.com/1148541
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#41}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
Change fileSystem.requestDownloads to stable channel
7967048 
Since all launch bits are flipped, change it to stable channel

BUG=879272
TEST=build pass
TBR=henryhsu@chromium.org

(cherry picked from commit bbef3a5)

Change-Id: I338c72a0700807eac4153ba4b4f17784a88b77de
Reviewed-on: https://chromium-review.googlesource.com/1201511
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588342}
Reviewed-on: https://chromium-review.googlesource.com/1205973
Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#41}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Fix accessibility support for MD incognito NTP
6bfd522 
Use TextViewWithClickableSpan for the subtitle text so that it responds
to accessibility events when the learn more link is appended to the end.
Also update the XML to make the root view focusable instead of the
scroll view, which fixes an issue where focus was previously going to a
child of the ScrollView instead of the container.

BUG=894844,757017

Change-Id: I737d3aa8cbe03064caa95065a6ce07ba41e6194e
Reviewed-on: https://chromium-review.googlesource.com/c/1278797
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599287}(cherry picked from commit 6cde412)
Reviewed-on: https://chromium-review.googlesource.com/c/1283479
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#41}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
child user: Disable quick unlock when authentication is disabled for …
d6e2f53 
…user

Time limits feature allows to lock the device of child user. When device
is lock child user should not be able to authenticate to the session.
To achieve that request to disable authentication should not be passed
directly to views lock screen UI. Instead request is passed to ScreenLocker
that disable authentication attempts (password, fingerprint, PIN) for the
requested user.

Bug: 910332
Tests: ScreenLockerTest + manually
Change-Id: I41b49e98f20e149945b35da18216896fb265fec4
Reviewed-on: https://chromium-review.googlesource.com/c/1355921
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612902}(cherry picked from commit c8b19fe)
Reviewed-on: https://chromium-review.googlesource.com/c/1361825
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#41}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
Fix redirects losing the |new_url| parameter from URLLoaderThrottle w…
356d3bb 
…ith network service if a webRequest extension is installed.

Since r622685, we always reset the target URLLoader inside WebRequestProxyingURLLoaderFactory::InProgressRequest on a redirect.. That means that we need to persist the new_url parameter to WebRequestProxyingURLLoaderFactory::InProgressRequest::FollowRedirect.

TBR=jam@chromium.org

(cherry picked from commit 7223984)

Bug: 925865
Change-Id: Ib0f7b7d0d2a80aec24988ccd6d1e65c9ae5b327f
Reviewed-on: https://chromium-review.googlesource.com/c/1440061
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626623}
Reviewed-on: https://chromium-review.googlesource.com/c/1443541
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#41}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
Fix an NTP texture issue
8d55430 
I had previously disabled texture capture when the NTP was scrolled to
fix issue 922909, but it caused another issue with side swipe when the
NTP was scrolled and Duet is enabled. The original fix is no longer
needed due to other changes. Notably, we allow texture captures while in
the tab switcher now.

BUG=938231

Change-Id: Iacb209594e12a04f180b18343b6f51205b338c53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512707
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639269}(cherry picked from commit 3ded53e0bebf2b23ccbe48940765ee2f64565dc1)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518194
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#41}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ghostoy @rogerwang