Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-remote="<all_urls>" doesn't work for 'file://' scheme #6860

Closed
mkazlauskas opened this issue Nov 7, 2018 · 2 comments
Closed

node-remote="<all_urls>" doesn't work for 'file://' scheme #6860

mkazlauskas opened this issue Nov 7, 2018 · 2 comments

Comments

@mkazlauskas
Copy link

mkazlauskas commented Nov 7, 2018

NWJS Version : 0.34.1
Operating System : Linux x64

Expected behavior

Specifying "node-remote": "<all_urls>" should work for file:// scheme

Actual behavior

Node globals are not available

How to reproduce

mkazlauskas/node-remote-bug

Additional request

I also need node integration on <iframe src="about:blank">. It doesn't have any of the allowed schemes for the URL pattern, so it's not a bug. Would you consider making a change/feature that either:

  • about:blank inherits parent frame type (node/normal)
  • Adding additional wildcard pattern, like "*" that would literally mean any URL, including about:blank
  • Enabling node integration on inject_js_* script (Electron does that with preload scripts), so they're available for the developer that directly uses nw.js and not the loaded page.
@TheJaredWilcurt
Copy link
Member

Issue also present in Windows

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants