Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function enterfullscreen brokes app on MacOS #7254

Closed
hnrqsss opened this issue Dec 3, 2019 · 6 comments
Closed

Function enterfullscreen brokes app on MacOS #7254

hnrqsss opened this issue Dec 3, 2019 · 6 comments
Assignees

Comments

@hnrqsss
Copy link

hnrqsss commented Dec 3, 2019

NWJS Version : 0.42.5 and 0.42.6
Operating System : MacOS X 10.14.6
NodeJS: v11.6.0 and v13.1.0

Expected behavior

Window.enterFullscreen()

Should set the app to fullscreen mode

Actual behavior

The app closes

Error log:

nwjs Helper (GPU)[23487:233334] PLClientLogging: unknown permission type 2
2019-12-03 16:52:39.303 nwjs Helper (GPU)[23487:233334] PLClientLogging: unknown permission type 2
2019-12-03 16:53:15.873 nwjs[23482:233278] *** Assertion failure in -[NativeWidgetMacNSWindow titlebarAccessoryViewControllers], /BuildRoot/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1671.60.109/AppKit.subproj/NSWindow.m:3439
Received signal 4 <unknown> 7fff373ec867
 [0x00010bd973f9]
 [0x00010bcb9553]
 [0x00010bd97311]
 [0x7fff65b58b5d]
 [0x000000001d82]
 [0x7fff373ec748]
 [0x7fff374ad0d1]
 [0x7fff39b1ca69]
 [0x7fff641a1edd]
 [0x7fff62bfa19e]
 [0x7fff62bedc7e]
 [0x7fff6419fe35]
 [0x7fff3702099a]
 [0x7fff37554a75]
 [0x7fff3797ceb5]
 [0x7fff37555fac]
 [0x7fff37acc63d]
 [0x00010df33ea2]
 [0x00010ee3a001]
 [0x00010ecdbb41]
 [0x00010e72d6f5]
 [0x000109cf2a54]
 [0x000109cf4b65]
 [0x000109cf52c6]
 [0x000109d1a6d1]
 [0x000109d1a5c6]
 [0x00010e757c5d]
 [0x000109a684ff]
 [0x000109704b12]
 [0x00010c951931]
 [0x00010bd2fbaf]
 [0x00010bd45551]
 [0x00010bd45a79]
 [0x00010bcde1b3]
 [0x00010bccfc5a]
 [0x00010bcdd99f]
 [0x7fff39a0ede3]
 [0x7fff39a0ed89]
 [0x7fff399f274b]
 [0x7fff399f1d15]
 [0x7fff399f161e]
 [0x7fff38c501ab]
 [0x7fff38c4fee5]
 [0x7fff38c4fc76]
 [0x7fff36fe877d]
 [0x7fff36fe746b]
 [0x00010b820e70]
 [0x00010bccfc5a]
 [0x00010b820da4]
 [0x7fff36fe1588]
 [0x00010bcdedac]
 [0x00010bcdd308]
 [0x00010bd45e68]
 [0x00010bd0d527]
 [0x00010b8260a7]
 [0x00010955f77b]
 [0x000109561372]
 [0x00010955c847]
 [0x00010b619212]
 [0x00010b618e40]
 [0x00010e5c1b6b]
 [0x00010b618074]
 [0x00010845e89b]
 [0x00010838a984]
 [0x7fff6596d3d5]
 [0x000000000002]
[end of stack trace]
[1203/165315.882722:WARNING:process_memory_mac.cc(93)] mach_vm_read(0x7ffee7875000, 0x2000): (os/kern) invalid address (1)
[1203/165315.993692:WARNING:system_snapshot_mac.cc(42)] sysctlbyname kern.nx: No such file or directory (2)

How to reproduce

Window.enterFullscreen()

@rogerwang
Copy link
Member

Does --disable-features=nw2 make any difference there?

@hnrqsss
Copy link
Author

hnrqsss commented Dec 4, 2019

Does --disable-features=nw2 make any difference there?

Yeah! Works, thanks.
Is this in the docs?

@hnrqsss hnrqsss closed this as completed Dec 4, 2019
@rogerwang
Copy link
Member

I'll reopen this since it's just a workaround.

@rogerwang rogerwang reopened this Dec 4, 2019
@rogerwang rogerwang self-assigned this Dec 7, 2019
@rogerwang
Copy link
Member

It works for me with this build: http://dl.nwjs.io/live-build/nw43/20191207-162000/0181cca2f/v0.43.0/

close for now.

@hnrqsss
Copy link
Author

hnrqsss commented Dec 9, 2019

It works for me with this build: http://dl.nwjs.io/live-build/nw43/20191207-162000/0181cca2f/v0.43.0/

close for now.

Ok, i'll try it both windows and Mac

@hnrqsss
Copy link
Author

hnrqsss commented Dec 13, 2019

On my real app keeping crash but i create a parallel project to test it and work, probably i did something wrong on my app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants