-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local sourcemaps can not be parsed in 0.44.1 #7373
Comments
We have the same problem - devtools is full with all the sourcemaps failed errors and makes debugging really painful - hope @rogerwang can solve it soon |
Thanks for the sample but it doesn't include the source code in coffeescript? |
Ah, somehow I assumed that this source map included sources as that's how we typically generate our source maps with webpack, my bad. Anyway, downloading js/main.coffee does not change the outcome - we would still get warning about parsing of .../js/main.js.map and it still would not show .../js/main.coffee in the source tree. Here is updated example.
|
This is fixed in git and will be available in the next nightly build. |
Not sure if this is the same as #4730, but maybe we are simply missing some configuration option here to allow local source maps.
It seems that source maps that are included as part of packaged app have not been working for a while, even though they are working for javascript that is loaded remotely.
Staring with 0.44.x new warning is printed in console that potentially provides some insights on the issue.
In 0.42.x - 0.43.x it does not print the warning, but it does not look like maps are working either, not sure.
NWJS Version : 0.44.1
Operating System : macOS Catalina (10.15.3)
Expected behavior
Source maps included packaged into the app should be properly reflected in source tree.
Actual behavior
Warning is printed the console and sources referenced in the source maps are not available in the source tree / search.
How to reproduce
nwjs-sourcemaps-test-local.zip
At the same time, source map is processed correctly when loaded from remote url
nwjs-sourcemaps-test-remote.zip
The text was updated successfully, but these errors were encountered: