Event 'open' on app is triggered once

[panther7]

Win 10 (x64)

• NWjs 0.62.2 - ok
• NWjs 0.63.0 - fail

manifest.json:

{
  "name": "test",
  "version": "0.1",

  "app": {
    "background": {
      "scripts": ["init.js"]
    }
  },

  "permissions": [
      "webview",
      "<all_urls>",
      "node",
      "proxy"
  ]
}

init.js:

(function () {
    // open dev tools
    chrome.developerPrivate.openDevTools({ renderViewId: -1, renderProcessId: -1, extensionId: chrome.runtime.id });
    // listener
    nw.App.on('open', (params) => console.log('onOpen', params));
})();

test case:

nw.exe "https://nwjs.io" // open event is triggered
nw.exe "https://nwjs.io" // nothing
nw.exe "https://nwjs.io" // nothing

@rogerwang

[sysrage]

I am also seeing this issue. It happens with 0.63.0 in both Linux and Windows.

An odd error message is also appearing, every time the app is launched:

[0405/104534.014465:ERROR:zip_reader.cc(140)] Cannot open ZIP from file handle 3

[sysrage]

I created a test to find this regression and it helped narrow-down the behavior. It seems that any event handlers attached to the open event are removed once they fire...

This shows the bug in action. After the first open event, the remaining 5 events do not trigger the event handler:

    const util = require('util');
    const exec = util.promisify(require('child_process').exec);

    let eventFired;
    nw.App.on('open', (params) => {
      console.log('params', params);
      eventFired = true;
    });

    const testOpenEvent = async () => {
      eventFired = false;
      const result = await exec(`${process.argv} ${nw.App.startPath} --testing`);
      if (!eventFired) return false;
      return true;
    };

    (async () => {
      for (let i = 0; i <= 5; i++) {
        console.log(`Test attempt: ${i}`);

        if (! await testOpenEvent()) {
          console.log('FAIL: The `open` event did not fire!');
        }
      }
    })();

However, if the event handler is re-attached to the open event every time, it works as expected:

    const util = require('util');
    const exec = util.promisify(require('child_process').exec);

    const testOpenEvent = async () => {
      let eventFired = false
      nw.App.on('open', (params) => {
        console.log('params', params);
        eventFired = true;
      });

      const result = await exec(`${process.argv} ${nw.App.startPath} --testing`);
      if (!eventFired) return false;
      return true;
    };

    (async () => {
      for (let i = 0; i <= 5; i++) {
        console.log(`Test attempt: ${i}`);

        if (! await testOpenEvent()) {
          console.log('FAIL: The `open` event did not fire!');
        }
      }
    })();

[panther7]

Maybe same issue with other events like nw.App.on("reopen", callback).

[arudnev]

On macOS the reopen event is fired only the first time when you click on the app icon in the dock after initial app start, in versions prior to 0.63.0 it was firing every time

[panther7]

Any news?

[rogerwang]

This is caused by https://chromium-review.googlesource.com/c/chromium/src/+/3233175
Will fix it soon.

[rogerwang]

This is fixed in git and will be available in the next nightly build.

[anurag-2911]

I have fixed this issue by adding my function in nw.App.onOpen.addListener and in this case it doesn't remove the listener.