Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] updated documentation for building NW.js #5558

Closed
wants to merge 1 commit into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Dec 15, 2016

Updated followings for Building NW.js.md

  • Clear out the build steps
    • merged GN/GYP into one step
    • merged build nwjs/Node into one step
  • Added descriptions for GN/GYP arguments
  • Added sections for dist target
  • Removed outdated Xcode warnings
  • Corrected external links for Build Faster section

Updated followings for Enable Proprietary Codecs.md

  • Removed invalid step of downloading libc++
  • Updated dummy BUILD.gn script

fixed #5555

Updated followings for `Building NW.js.md`

* Clear out the build steps
   * merged GN/GYP into one step
   * merged build nwjs/Node into one step
* Added descriptions for GN/GYP arguments
* Added sections for `dist` target
* Removed outdated Xcode warnings
* Corrected external links for Build Faster section

Updated followings for `Enable Proprietary Codecs.md`

* Removed invalid step of downloading libc++
* Updated dummy BUILD.gn script

fixed nwjs#5555
````
We support component build: `is_component_build = true` for faster development cycle. It should be used when you are trying to build debug version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

```
* `nwjs_sdk` (`bool`): build NW.js SDK flavor with DevTools enabled
* `is_debug` (`bool`): build in debug mode with debugable symbols and no optimization
* `is_component_build` (`bool`): link binaries into separate dynamic libraries. This will speed up the build in debug mode.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerwang It's mentioned here.

@stale
Copy link

stale bot commented Feb 16, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 16, 2018
@stale stale bot closed this Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants