Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu.popup misplaced when zoomLevel is set #718

Closed
wants to merge 3 commits into from

Conversation

owenc4a4
Copy link
Contributor

No description provided.

@zhchbin
Copy link
Contributor

zhchbin commented May 16, 2013

Hi @owenc4a4 Just my personal suggestion, why not add a private method in the menu.h and menu.cc that can get the real x and y instead of doing the same thing in three platform? In that way you can find that just little repeated code in three platforms.

@owenc4a4
Copy link
Contributor Author

Good idea

From: Chaobin.Zhang [mailto:notifications@github.com]
Sent: Thursday, May 16, 2013 11:17 AM
To: rogerwang/node-webkit
Cc: Ma, Donghao
Subject: Re: [node-webkit] Fix menu.popup misplaced when zoomLevel is set (#718)

Hi @owenc4a4https://github.com/owenc4a4 Just my personal suggestion, why not add a private method in the menu.h and menu.cc that can get the real x and y instead of doing the same thing in three platform? In that way you can find that just little repeated code in three platform.


Reply to this email directly or view it on GitHubhttps://github.com//pull/718#issuecomment-17978741.

@rogerwang
Copy link
Member

This PR doesn't apply on nw13 architecture any more.

@rogerwang rogerwang closed this Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants