Added NWNX_ON_ATTACK_TARGET_CHANGE_BEFORE/AFTER events #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daztek
reviewed
Jul 25, 2023
| uint32_t nParamType8, void* pParameter8, uint32_t nParamType9, void* pParameter9, uint32_t nParamType10, void* pParameter10, | ||
| uint32_t nParamType11, void* pParameter11, uint32_t nParamType12, void* pParameter12) | ||
| { | ||
| auto bOriginalCalled = false; |
There was a problem hiding this comment.
Would like this auto to be explicitly bool. Same for the auto oidXXX ones further below and in the other hook, ObjectID/OBJECT_ID in this case.
auto should only be used when the type is really obvious, due to a cast or a Utils::AsNWSCreature(pObject); like auto *pCreature has below.
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added
Utils::StringToObjectID()as I did need that.