Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: NWNX_Damage - damage event did not fire for doors #1689

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Fixed: NWNX_Damage - damage event did not fire for doors #1689

merged 2 commits into from
Aug 7, 2023

Conversation

Cjreek
Copy link
Contributor

@Cjreek Cjreek commented Jul 27, 2023

Now it does.

@Daztek
Copy link
Member

Daztek commented Aug 1, 2023

I'd say it's more of a change rather than a fix. So it's probably better to list it under Changed in the changelog, also some driveby formatting seems to have snuck in!

@Cjreek
Copy link
Contributor Author

Cjreek commented Aug 1, 2023

also some driveby formatting seems to have snuck in!

Yes, I removed unnecessary, ugly empty lines. Do you want me to put them back in? 🤐

@Cjreek
Copy link
Contributor Author

Cjreek commented Aug 5, 2023

Changed the changelog

@Daztek Daztek merged commit 65dfd92 into nwnxee:master Aug 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cjreek @Daztek