Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with purty #10

Closed
joneshf opened this issue Jun 21, 2019 · 4 comments
Closed

Integration with purty #10

joneshf opened this issue Jun 21, 2019 · 4 comments

Comments

@joneshf
Copy link

joneshf commented Jun 21, 2019

Howdy!

I maintain a source code formatter: purty. I'd like to add support for using it from VS Code. The goal here is that formatting PS code be dead simple (not many install steps, no extra binaries to download, etc.).

I'd like the burden on you to be as minimal as possible, so when the API of purty changes, I expect to update whatever's necessary to work here. Would it be easier if I maintained an extension and this extension depended on it somehow (I don't know enough about the VS Code ecosystem)? There is an extension specifically for purty, but its releases have some drift from purtys. I'd like to minimize that as much as possible.

What are your thoughts?

@mvakula
Copy link

mvakula commented Jun 25, 2019

If needed I can make a PR for purty support here.

P.S. I also updated and published vscode-purty extension to work with the latest purty release.

@nwolverson
Copy link
Owner

Certainly my feeling is that a separate extension doing code formatting is a good thing. I don't think this extension should depend on it, as it is just the bare minimum syntax highlighting etc.

I thought that there was a way to recommend extensions, but it only seems to be per workspace not as a weak dependency of an extension? Possibly could add a dependency to ide-purescript which is already kitchen sink

@nwolverson
Copy link
Owner

At a bare minimum if someone wants to PR the readmes of this and ide-purescript before I get around to it, please do

@nwolverson
Copy link
Owner

Code formatting via purty is now provided via the purescript-language-server (or the extension linked previously) so I don't think this issue is relevant any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants