Fixes #1040
Fixes #1040
Conversation
- fix macos symlinks - fix ffmpeg download
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
|
Is there anything else needed? Must I change version number or anything? |
Nope, releases have been automated now. Couple more questions and should be good to go. Want to ask detailed questions and record them as code comments so that I don't regress on the fixes you implement. |
| const linkTarget = Buffer.concat(chunks).toString('utf8').trim(); | ||
|
|
||
| // Check if the symlink or a file/directory already exists at the destination | ||
| if (fs.existsSync(entryPathAbs)) { |
There was a problem hiding this comment.
Does rm not delete symlinks? Why should there be existing symlinks?
|
@ayushmanchhabra I merged this PR but I see version is still 4.6.1 - should I manually bump version? |
|
Yup thats cuz you merged instead of squash and merge, let me try squashing the last few commits |
|
ah apologies - I'll bear that in mind for futuer |
|
All good, a simple squash and merge and voila! (I should have updated the PR title and description before approving tbh) |
I tried the latest version on macOS and a lot of things broke.
Here are the fixes
BEGIN_COMMIT_OVERRIDE
fix(get): create symlinks after extracting files from zip
fix(get): do not use
options.downloadUrlto set ffmpeg download urlEND_COMMIT_OVERRIDE