PR test coverage requirement

[zkrige]

Any new PR's should have minimum test coverage requirements of 80% - but only for the changes.

so if theres 20 lines changed, 16 of them should be covered by tests

[ayushmanchhabra]

What's weird is that in both #1035 and #1040, the symlinks test passed in GitHub CI but failed on your local machine (or was it CircleCI?).

[zkrige]

that is weird. it was failing on my local Mac AND on circle build. When I get a chance I'll review those tests to check if they're testing the right thing

[zkrige]

ah - the decompress.test.js doesnt actually test if symlinks exist after extracting. it just runs runs a decompress and then continues. the macOS one should ALSO check that symlinks exist once decompress has finished

[ayushmanchhabra]

Any new PR's should have minimum test coverage requirements of 80% - but only for the changes.

https://coveralls.io/ ?

[zkrige]

I think this is more relevant https://github.com/Bachmann1234/diff_cover

[ayushmanchhabra]

This has been resolved in #1120. I forgot to link the issue in the PR.

[ayushmanchhabra]

Accidently closed