fix(core): use for of on loop on project Map (#661)

* fix(core): use for of on loop on project Map * chore(core): fixup unit test --------- Co-authored-by: AgentEnder <craigorycoppola@gmail.com>
nx-dotnet · Mar 22, 2023 · c9d31d7 · c9d31d7
1 parent 0bd6391
commit c9d31d7
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 3 deletions.
diff --git a/packages/core/src/migrations/1.8.0/remove-output-option.spec.ts b/packages/core/src/migrations/1.8.0/remove-output-option.spec.ts
@@ -10,10 +10,13 @@ import * as utils from '@nx-dotnet/utils';
 
 import update from './remove-output-option';
 
+const projects = new Map();
+
 jest.mock('@nx-dotnet/utils', () => ({
   ...(jest.requireActual('@nx-dotnet/utils') as typeof utils),
   getProjectFileForNxProject: () =>
     Promise.resolve('apps/my-app/my-app.csproj'),
+  getNxDotnetProjects: () => projects,
 }));
 
 describe('remove-output-option', () => {
@@ -33,6 +36,18 @@ describe('remove-output-option', () => {
       </Root>`,
     );
 
+    projects.clear();
+    projects.set('my-app', {
+      root: 'apps/my-app',
+      targets: {
+        build: {
+          executor: '@nx-dotnet/core:build',
+          options: {
+            output: 'dist/apps/my-app',
+          },
+        },
+      },
+    });
     addProjectConfiguration(tree, 'my-app', {
       root: 'apps/my-app',
       targets: {
@@ -63,6 +78,19 @@ describe('remove-output-option', () => {
       </Root>`,
     );
 
+    projects.clear();
+    projects.set('my-app', {
+      root: 'apps/my-app',
+      targets: {
+        build: {
+          executor: '@nx-dotnet/core:build',
+          outputs: ['{options.output}'],
+          options: {
+            output: 'dist/apps/my-app',
+          },
+        },
+      },
+    });
     addProjectConfiguration(tree, 'my-app', {
       root: 'apps/my-app',
       targets: {
@@ -96,6 +124,18 @@ describe('remove-output-option', () => {
       </Root>`,
     );
 
+    projects.clear();
+    projects.set('my-app', {
+      root: 'apps/my-app',
+      targets: {
+        build: {
+          executor: '@nx-dotnet/core:build',
+          options: {
+            output: 'dist/apps/my-app',
+          },
+        },
+      },
+    });
     addProjectConfiguration(tree, 'my-app', {
       root: 'apps/my-app',
       targets: {

diff --git a/packages/utils/src/lib/utility-functions/workspace.ts b/packages/utils/src/lib/utility-functions/workspace.ts
@@ -97,9 +97,7 @@ export async function getNxDotnetProjects(
 ): Promise<Map<string, ProjectConfiguration>> {
   const allProjects = getProjects(host);
 
-  for (const key in allProjects) {
-    const p = allProjects.get(key);
-
+  for (const [key, p] of allProjects) {
     let isNetProject = false;
     for (const pattern of ['*.csproj', '*.fsproj', '*.vbproj'] as const) {
       const matches = await glob(pattern, p?.root);