Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] test suites are included in the NPM package #34

Closed
LayZeeDK opened this issue May 5, 2021 · 3 comments
Closed

[BUG] test suites are included in the NPM package #34

LayZeeDK opened this issue May 5, 2021 · 3 comments
Labels
bug Something isn't working outdated

Comments

@LayZeeDK
Copy link
Contributor

LayZeeDK commented May 5, 2021 •
edited
Loading

Describe the bug
*.spec.ts files are included in the @nx-dotnet/core package. I noticed them for the generators.

To Reproduce
Steps to reproduce the behavior:

  1. npm install --save-dev @nx-dotnet/core
  2. Look in node_modules/@nx-dotnet/core/(...)

Expected behavior
No test suites are included in an NPM package.

Environment:

  • Version: 0.4.1
  • Affected Packages: @nx-donet/core
@LayZeeDK LayZeeDK added bug Something isn't working needs-triage This issue has yet to be looked over by a core team member labels May 5, 2021
@AgentEnder AgentEnder removed the needs-triage This issue has yet to be looked over by a core team member label May 5, 2021
@AgentEnder
Copy link
Member

This should be fixed in the next patch version, but is an issue within the Nx plugin generator by default.

I created nrwl/nx#5563 to handle this.

AgentEnder added a commit that referenced this issue May 5, 2021
@AgentEnder
fix(core): #34 remove spec files from built plugin
f075046
github-actions bot pushed a commit that referenced this issue May 5, 2021
@semantic-release-bot
release(): 0.4.2 [skip ci]
f8dc038 
## [0.4.2](v0.4.1...v0.4.2) (2021-05-05)

### Bug Fixes

* **core:** [#34](#34) remove spec files from built plugin ([f075046](f075046))
* **core:** [#35](#35) dry run is not passed to dotnet new ([8e0b398](8e0b398))
github-actions bot pushed a commit that referenced this issue May 5, 2021
@semantic-release-bot
release(): 0.4.2-dev.1 [skip ci]
282e44f 
## [0.4.2-dev.1](v0.4.1...v0.4.2-dev.1) (2021-05-05)

### Bug Fixes

* **core:** [#34](#34) remove spec files from built plugin ([f075046](f075046))
* **core:** [#35](#35) dry run is not passed to dotnet new ([8e0b398](8e0b398))
github-actions bot pushed a commit that referenced this issue May 6, 2021
@semantic-release-bot
release(): 0.5.0-dev.1 [skip ci]
2f6991b 
# [0.5.0-dev.1](v0.4.1...v0.5.0-dev.1) (2021-05-06)

### Bug Fixes

* **core:** [#34](#34) remove spec files from built plugin ([f075046](f075046))
* **core:** [#35](#35) dry run is not passed to dotnet new ([8e0b398](8e0b398))

### Features

* **core:** add executor for dotnet publish [#33](#33) ([#36](#36)) ([f7cbd27](f7cbd27))
AgentEnder pushed a commit that referenced this issue May 6, 2021
@semantic-release-bot @AgentEnder
release(): 0.4.2-dev.1 [skip ci]
401c0bb 
* **core:** [#34](#34) remove spec files from built plugin ([f075046](f075046))
* **core:** [#35](#35) dry run is not passed to dotnet new ([8e0b398](8e0b398))
@AgentEnder
Copy link
Member

Associated PR in @nrwl/nx has been merged.

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LayZeeDK @AgentEnder