Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): move generator not updating paths correctly #767

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

Tungsten78
Copy link
Contributor

Issue

project.json paths weren't being updated correctly

Steps to reproduce

  • nx g @nx-dotnet/core:lib my-lib
  • nx g @nx-dotnet/core:move --projectName my-lib --destination a/b/c
  • nx g @nx-dotnet/core:move --projectName a-b-c --destination my-lib

Expected result

  • sourceRoot, outputPaths, etc should be pathed correctly

Actual result

image

Note: when this issue was discovered we noted $schema was also incorrect following the generator. This hasn't been reproducible but does show itself in the added unit test.

@nx-cloud
Copy link

nx-cloud bot commented Oct 3, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f5e4001. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


⌛ The following target is in progress

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the most part, one sm change requested that I think should clean it up.

packages/core/src/generators/move/generator.ts Outdated Show resolved Hide resolved
packages/core/src/generators/move/generator.ts Outdated Show resolved Hide resolved
packages/core/src/generators/move/generator.ts Outdated Show resolved Hide resolved
@AgentEnder
Copy link
Member

Lgtm, can you take care of the sonar code smell?

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder merged commit 6398a06 into nx-dotnet:master Oct 6, 2023
7 checks passed
@AgentEnder
Copy link
Member

Awesome, thanks for the contribution 🎉

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants