Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support allSourceTags (#768) and wildcards in check-module-boundaries.js #771

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

Tungsten78
Copy link
Contributor

@Tungsten78 Tungsten78 commented Oct 6, 2023

Addresses #768

Also adds regex and glob matching - another feature of @nx/eslint-plugin

@nx-cloud
Copy link

nx-cloud bot commented Oct 6, 2023

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Tungsten78 👋

Thanks for the contribution. There are a few changes that I'd like before merging, but overall it's looking good and is a great addition to get things up to parity.

packages/core/src/tasks/check-module-boundaries.ts Outdated Show resolved Hide resolved
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, few sm changes

packages/core/src/tasks/check-module-boundaries.ts Outdated Show resolved Hide resolved
packages/core/src/tasks/check-module-boundaries.ts Outdated Show resolved Hide resolved
@Tungsten78
Copy link
Contributor Author

I'm not really sure what's up with the failing e2e, I don't see the function call it's referring to??

image

@AgentEnder
Copy link
Member

Can you rebase the PR?

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder
Copy link
Member

@Tungsten78 I seen the comment about the graph processing failing, did you figure that out locally?

@Tungsten78
Copy link
Contributor Author

t the graph processing faili

@Tungsten78 I seen the comment about the graph processing failing, did you figure that out locally?

Yes, it was environment specific (yarn install related I believe). All good, thanks for checking.

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution 🎉, I'm planning a release soon with the Nx 16 updates.

@AgentEnder AgentEnder merged commit b55c597 into nx-dotnet:master Oct 11, 2023
7 checks passed
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants