dotnet format is in dotnet sdk since dotnet 6

[maxisam]

nx-dotnet/packages/core/src/executors/format/executor.ts

Lines 76 to 88 in 84f35f1

	if (majorVersion === 6) {
	dotnetClient.installTool(
	'dotnet-format',
	'6.*',
	'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json',
	);
	} else if (majorVersion === 7) {
	dotnetClient.installTool(
	'dotnet-format',
	'7.*',
	'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json',
	);
	} else {

Question about this,

I wonder if we need this for dotnet version >= 6

according to the doc, dotnet format should be included

  if (forceToolUsage || majorVersion < 6) {
    ensureFormatToolInstalled(context, dotnetClient, majorVersion);
  }

based on above logic, it seems like only dotnet 6.0.0 - 6.0.203 or dotnet <6 might run it.

[AgentEnder]

For .NET 6 - 6.203 or whatever there was a bug where we had to still use the tool

[maxisam]

Thanks for explanation.

I guess this is not needed. Originally I was wonder if I need to add dotnet 8. Now I think we don't even need 7 here.

else if (majorVersion === 7) {
    dotnetClient.installTool(
      'dotnet-format',
      '7.*',
      'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json',
    );
  }

[AgentEnder]

IIRC there was a different bug with earlier versions of the built in tool in the .NET 7 releases, after that was fixed I may have cleaned up when it would be required.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.