Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Check SDK and tool installation before running format command #204

Merged
merged 4 commits into from
Oct 14, 2021
Merged

fix(core): Check SDK and tool installation before running format command #204

merged 4 commits into from
Oct 14, 2021

Conversation

bcallaghan-et
Copy link
Collaborator

Check if the format tool is installed (through the tool manifest or bundled with the SDK) rather than re-installing it every time. Also pass the --check option only if running SDK 5 or lower, and pass the --verify-no-changes option if running SDK 6 or newer.

Resolves #179 and #202

Ben Callaghan added 2 commits October 14, 2021 11:24
fix(core): install dotnet-format only if necessary
7210a6b 
Do not install the tool if it is already installed or if part of the SDK

Fixes #202
fix(core): pass verifyNoChanges option on .NET 6+
47afffd 
Pass the correct "check" option depending on the SDK version

Fixes #179
@nx-cloud
Copy link

nx-cloud bot commented Oct 14, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 265abcc. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=e2e --all
#000000 nx run-many --all --target=build --with-deps
#000000 nx affected --target=test --base=origin/master --parallel
#000000 nx affected --target=build --base=origin/master --parallel --with-deps
#000000 nx affected --target=lint --base=origin/master --parallel

Sent with 💌 from NxCloud.

bcallaghan-et and others added 2 commits October 14, 2021 17:08
@bcallaghan-et @AgentEnder
chore(core): remove unused import
af1b98e 
Remove an unused import from a test file

Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
chore(core): rename ensure function to be more specific
265abcc 
Rename the ensureToolInstalled method to specify what tool is installed
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder changed the title Check SDK and tool installation before running format command fix(core): Check SDK and tool installation before running format command Oct 14, 2021
@AgentEnder AgentEnder merged commit 3ad6291 into nx-dotnet:master Oct 14, 2021
github-actions bot pushed a commit that referenced this pull request Oct 14, 2021
@semantic-release-bot
release: 1.4.3 [skip ci]
2aad1ae 
## [1.4.3](v1.4.2...v1.4.3) (2021-10-14)

### Bug Fixes

* **core:** Check SDK and tool installation before running format command ([#204](#204)) ([3ad6291](3ad6291)), closes [#179](#179) [#202](#202)

Oct 14, 2021, 11:24 PM
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bcallaghan-et bcallaghan-et deleted the check-format-tool-installation branch July 5, 2022 16:57
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] nx lint fails on dotnet project
2 participants
@bcallaghan-et @AgentEnder