Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow open solutions with Visual Studio #563

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

pedrolamas
Copy link
Contributor

Fixes #548

@nx-cloud
Copy link

nx-cloud bot commented Nov 10, 2022

@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AgentEnder
Copy link
Member

@tzuge After the CI passes on this one, I'll go ahead and merge it. I prefer the System.IO.Path impl personally, but until we can figure out whats keeping it from working in VS, this should do too.

@AgentEnder AgentEnder merged commit 042a9db into nx-dotnet:master Nov 11, 2022
github-actions bot pushed a commit that referenced this pull request Nov 11, 2022
## [1.16.1](v1.16.0...v1.16.1) (2022-11-11)

### Bug Fixes

* **core:** allow open solutions with Visual Studio ([#563](#563)) ([042a9db](042a9db)), closes [#548](#548)
* **core:** usage of MSBuildProjectDirRelativePath should handle paths with white space ([a939c4b](a939c4b))

Nov 11, 2022, 4:02 PM
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
@pedrolamas pedrolamas deleted the pedrolamas/fix-vs-msbuild branch November 7, 2023 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Visual Studio cannot open projects due to "Invalid static method invocation syntax" errors
2 participants