Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: reference existing project file path #76

Merged
merged 1 commit into from
Aug 4, 2021
Merged

FIX: reference existing project file path #76

merged 1 commit into from
Aug 4, 2021

Conversation

FairlieAgile
Copy link
Contributor

Running "nx dep-graph" will currently generate the following error:
nx-dotnet encountered an error parsing dependencies for 'project name'

@nx-cloud
Copy link

nx-cloud bot commented Aug 4, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 2ba1899. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=e2e --all
#000000 nx run-many --all --target=build --with-deps
#000000 nx affected --target=test --base=origin/master --parallel
#000000 nx affected --target=lint --base=origin/master --parallel
#000000 nx affected --target=build --base=origin/master --parallel --with-deps

Sent with 💌 from NxCloud.

AgentEnder
AgentEnder requested changes Aug 4, 2021
View reviewed changes
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Fairlie Agile. This is a silly mistake on my part, should have known better than to attempt a fix from an airport. I left a few comments, if you resolve these and amend your existing commit to fix the message format (should be fix(core): ...)

packages/core/src/graph/process-project-graph.ts Outdated Show resolved Hide resolved
packages/core/src/graph/process-project-graph.ts Outdated Show resolved Hide resolved
@AgentEnder AgentEnder force-pushed the master branch 2 times, most recently from f381273 to 07e0e94 Compare August 4, 2021 19:40
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AgentEnder AgentEnder merged commit 2e56afc into nx-dotnet:master Aug 4, 2021
github-actions bot pushed a commit that referenced this pull request Aug 4, 2021
@semantic-release-bot
release: 1.0.1 [skip ci]
ccbc8e6 
## [1.0.1](v1.0.0...v1.0.1) (2021-08-04)

### Bug Fixes

* **core:** dep-graph affected should work ([#76](#76)) ([2e56afc](2e56afc))

Aug 4, 2021, 8:47 PM
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FairlieAgile @AgentEnder