Doc tweaks, bug fixes. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to use replace() to override default list and view templates. Import of fs was missing from index.js. Noted that model name is morphed to produce template names, title string. Waterline populate() method doesn't take an array argument of attribute names -- must be called repeatedly, once for each attribute.
|
Approved! |
Shouldn't need to use replace() to replace default templates. Logged an issue for this, instead of changing documentation. Revised nxus-storage requires waterline 0.12, which provides a populate() method that accepts an array of links, so we don't need to iterate over the links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to use replace() to override default list and view templates.
Import of fs was missing from index.js.
Noted that model name is morphed to produce template names, title string.
Waterline populate() method doesn't take an array argument of
attribute names -- must be called repeatedly, once for each attribute.