Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove interfaces, classes in support of db inserts #2

Merged
merged 7 commits into from
May 11, 2017

Conversation

nicpottier
Copy link
Collaborator

No description provided.

Copy link
Member

@rowanseymour rowanseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the unintentional reverts in server.go

server.go Outdated
@@ -321,11 +318,13 @@ func (s *server) handleIndex(w http.ResponseWriter, r *http.Request) {

// RegisterHandler adds a new handler for a channel type, this is called by individual handlers when they are initialized
func RegisterHandler(handler ChannelHandler) {
registeredHandlers[handler.ChannelType()] = handler
if handlers == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs reverted

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.03%) to 67.623% when pulling cafef13 on no-interfaces into f74d45e on master.

@nicpottier nicpottier merged commit 3ac28a9 into master May 11, 2017
@nicpottier nicpottier deleted the no-interfaces branch May 11, 2017 19:46
nicpottier pushed a commit that referenced this pull request May 23, 2018
rowanseymour pushed a commit that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants