Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw exception if external handler is asked to update incoming message #1006

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Don't throw exception if external handler is asked to update incoming message #1006

merged 1 commit into from
Jan 5, 2017

Conversation

rowanseymour
Copy link
Member

Fixes https://github.com/rapidpro/rapidpro/issues/422. Also adds some real test coverage

@rowanseymour rowanseymour self-assigned this Jan 5, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 424611d on ext_channel_fix into 6d81ea8 on master.

nicpottier
nicpottier approved these changes Jan 5, 2017
View reviewed changes
Copy link
Collaborator

@nicpottier nicpottier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏭

@nicpottier nicpottier merged commit 9f1589a into master Jan 5, 2017
@nicpottier nicpottier deleted the ext_channel_fix branch January 5, 2017 18:09
@nicpottier nicpottier removed the review label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicpottier nicpottier nicpottier approved these changes

Assignees

@rowanseymour rowanseymour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rowanseymour @coveralls @nicpottier